Wikipedia talk:Twinkle/Archive 43
This is an archive of past discussions on Wikipedia:Twinkle. Do not edit the contents of this page. If you wish to start a new discussion or revive an old one, please do so on the current talk page. |
Archive 40 | Archive 41 | Archive 42 | Archive 43 | Archive 44 | Archive 45 | → | Archive 48 |
June 2020 Twinkle updates, features, and behaviors (2020-06-13) @6a11ff8
Got a big release this time around. You can now show rollback/revert links on Special:Recentchanges as well as page histories! These are both off by default, but you can enable them in your Twinkle preferences. You can also now choose to revert-in-place when on a user's contributions page or Recent Changes, allowing you to more effectively revert multiple revisions at once and do quick RC patrol. Also helpful is a new option for the warning menu that will attempt to autoselect the correct warning level based on whatever warnings are already present on a user's talk page! There's also a brand new XfD log, to go alongside the CSD and PROD logs. Turn it on in at WP:TW/PREF. There are a number of other improvements and bug fixes are present as well; a brief summary of some of the more notable items are below. Changes not otherwise attributed were made by User:Amorymeltzer.
- Revert and rollback:
- Add ability to enable rollback links on Special:Recentchanges and Special:Recentchangeslinked (off by default) (#942)
- Add ability to rollback-in-place on Contributions or Recentchanges (#947)
- Add revert links to history pages (off by default) (#942)
- Don't open user's talkpage unless/until the reversion is complete (#948)
- Add ability to enable rollback links on Special:Recentchanges and Special:Recentchangeslinked (off by default) (#942)
- Warn: Add option to autoselect warning levels 1-4 based off their recent prior warnings (#777)
- Xfd:
- Block:
- Tag:
- talkback: Add {{EFFPReply}} (#957, by Mdaniels5757)
- Welcome:
- Add {{welcome-retro}} (#939, by BrandonXLF)
- Update {{W-short}} (#958, by MJL)
- Speedy: Align A7 criteria labels with the actual criteria (#956) (#947, by Mdaniels5757)
- Arv: Update SPI tooltips (#942, by QEDK)
This section should serve as a catching ground should anything not work properly or if any new bugs crop up, as well as for any feedback or suggestions. There were a lot of changes behind the scenes, so feel free to ping me. As always, input is welcome at the GitHub repo as well. Finally, if you're interested in helping out with Twinkle development, there's a guideline to help new contributors get set up — check it out! ~ Amory (u • t • c) 18:11, 13 June 2020 (UTC)
Technical changes
Also, for the more technical folks, there were a few behind the scenes changes. There were a few bug fixes but most notably, SD0001 added:
- Promise support to
Morebits.wiki.api
(#765) - A brand new
Morebits.userspaceLogger
to handle adding to a userspace log (#878)- Used in speedy, prod, and xfd
~ Amory (u • t • c) 18:11, 13 June 2020 (UTC)
U/I problems for CSD with multiple reasons.
See this embarrasing sequence of attempts by me to delete a page with the correct log message. My original plan was to check "Tag with multiple criteria", use the G4 box to get the AfD page, and also Custom rationale to add the link to the SPI. To my surprise, when you click on multiple criteria, the custom box goes away. So, I was forced to just do custom, and try to cram all that information into a text box that's way too small to hold all the text. A few thoughts how this could be made better:
- Don't remove the custom option when you click multiple. Maybe relabel it "additional reason"?
- Make the custom criteria box much larger. Or at least re-sizeable.
- Provide a way to preview the rendered reason. Even better, auto-preview it in real time. This would have immediately made it obvious that I'd gotten the links wrong.
-- RoySmith (talk) 14:46, 12 June 2020 (UTC)
- The templates don't really support either/or AFAIK. That is, I don't think {{db-multiple}} allows for an additional reason. But, yes, the speedy tags should absolutely have a preview option when tagging, although you were deleting, right? ~ Amory (u • t • c) 17:52, 13 June 2020 (UTC)
- Amorymeltzer, Yes, in my case, I was deleting, but being able to preview the commit message still has value, so you can verify that the links are correct. And certainly making the text box bigger/resizable would be a good thing. -- RoySmith (talk) 22:13, 13 June 2020 (UTC)
Nomination for merging of {{subst:uw-blank1}} and {{subst:uw-blank2}}
{{subst:uw-blank1}} and {{subst:uw-blank2}} have been requested for merging with {{subst:uw-delete1}} and {{subst:uw-delete2}}, respectively. Admins, could you remove them from the user warn function when discussion is finished? –User456541 14:50, 15 June 2020 (UTC)
- The discussion is at Wikipedia:Templates for discussion/Log/2020 June 15#Uw-blank and Uw-delete. And the TW devs will likely keep it unless the TfD results in delete. {{reply to|Can I Log In}}'s talk page! 17:12, 15 June 2020 (UTC)
Having a centralised board for all tool template changes
As this is somewhat related to Twinkle's maintenance, I'm putting this here. A number of tools share the same templates as Twinkle, however, these templates are only marked with {{Twinkle standard installation}}
, which, as current only mentions Twinkle. I'm proposing the creation of a centralised board regarding these templates as having a board that would notify maintainers of bots, tools and scripts of changes that could cause disruption would be extremely useful, and probably resolve endless headaches where a maintainer would have to spend time going through various threads to work out what happened to a template. In addition, maintainers of documentation would also be notified regarding the changes and could update manually for users who prefer not to use tools. In the creation of this board, the Twinkle standard installation template would be redirected to a new template which would mention informing the board. I'm wondering what you guys think about this? Ed6767 talk! 13:50, 17 June 2020 (UTC)
- Ed6767 other than Templates used by Twinkle, there are Templates used by AutoWikiBrowser, Templates used by CheMoBot, and Templates used by the GAN page, all (semi-)automated used, and though I don't drop by at WP:TfD daily, I can tell you not many templates are nominated for merging or deletion. {{reply to|Can I Log In}}'s talk page! 16:44, 17 June 2020 (UTC)
Unrelated discussion regarding
{{RedWarn standard installation}} | ||
---|---|---|
|
Deletion sorting notice
When nominating an article to AfD using Twinkle, in the 'Choose deletion sorting categories' help text, the advice given to the user is rather limited: 'Select a few categories that are relevant to the subject of the article'. A couple of times in the past, I've selected categories like 'People' or 'USA', only be reverted and told that these are high-level categories that should only be used if I can't find a more specific category. I'm wondering whether we should offer the Twinkle user a bit more guidance on this - perhaps just by expanding the advisory text a bit, or alternatively by flashing up a warning along the lines of 'You have selected a high-level category; if possible choose a more specific one and remove this one'. Just a thought. (Courtesy ping to Northamerica1000, who I discussed this with elsewhere.) GirthSummit (blether) 11:08, 28 May 2020 (UTC)
- It would be great for something to be included asking users to use a more precise delsort category when possible. Folks just have not been following the directions listed atop the Wikipedia:WikiProject Deletion sorting/People page at all. I have been patrolling the page and removing errant entries for around a month now (link), but I can't do it forever. The page is meant to list miscellaneous article for deletion whose subjects do not fit into any of the other biographical delsort categories. Its purpose is not to list all biographical articles for deletion, but that's what is occurring. @Girth Summit: Thanks for the ping. North America1000 06:10, 1 June 2020 (UTC)
- @Northamerica1000 and Girth Summit:, would something in the tooltip like
Select a few categories that are specifically relevant to the subject of the article. Be as precise as possible; categories like People and USA should only be used when no other categories apply.'
work (new text in bold)? ~ Amory (u • t • c) 02:11, 2 June 2020 (UTC)- @Amorymeltzer: Something like that would be great, particularly for the People delsort page. It could also be added-in for users to refer to the documentation on the delsort pages for more information, because both provide guidance. However, it is important to distinguish that the U.S. delsort page is not as strict as the People delsort page. For example, per a recent discussion here, the guidelines were updated to add, "AfD discussions about people, organizations, companies and other entities that are known for activity on a national level in the United States can be listed on this page". North America1000 05:26, 2 June 2020 (UTC)
- @Amorymeltzer: Something along those lines would definitely be an improvement. People and USA were the two categories that I've been reverted on in the past, I'm not sure whether there are any others that we should mention in the tooltip text? Another thought - is it possible to bring up alt text when you hover the cursor over options in the list of categories? If that was possible we could put category-specific guidance there, so that it appears before you select that category. If that's not technically possible then sticking it all in the tooltip text would be fine. GirthSummit (blether) 07:41, 2 June 2020 (UTC)
- Okay well any suggestions for changes just say 'em and I can make it! I'm not sure about doing a tooltip for each, but I'm not sure whether it's a good idea: not readily discoverable, and a lot of extra text that may not be needed. What would be good, though, is we can make each selection a clickable link, so that the user can easily take a look at each page for reference. That'd be pretty straightforward since the pages share a naming convention. I think that plus a better tooltip would be grand. ~ Amory (u • t • c) 09:49, 2 June 2020 (UTC)
- Amorymeltzer, sounds good to me. I just took a run through a bunch of other 'high level' delsorting category pages, I'm not seeing any other edit notices about not including them, so it looks like it's just People and USA that we need to worry about. (This seems a bit strange to me - I'd have thought that something like 'Sport' would have been a similar sort of thing - but what do I know...) Your suggestion about clickable links looks good to me :) GirthSummit (blether) 13:23, 2 June 2020 (UTC)
- Okay well any suggestions for changes just say 'em and I can make it! I'm not sure about doing a tooltip for each, but I'm not sure whether it's a good idea: not readily discoverable, and a lot of extra text that may not be needed. What would be good, though, is we can make each selection a clickable link, so that the user can easily take a look at each page for reference. That'd be pretty straightforward since the pages share a naming convention. I think that plus a better tooltip would be grand. ~ Amory (u • t • c) 09:49, 2 June 2020 (UTC)
- @Northamerica1000 and Girth Summit:, would something in the tooltip like
- I intend to stop categorizing AfDs if I'm going to get a lecture every time for doing it wrong. [1] – bradv🍁 23:30, 4 June 2020 (UTC)
- @Bradv: As I stated on my talk page, the edit summary I left is just a standard c/p that I use when removing unnecessary entries from the People delsort page. It was not meant to come across as any sort of lecture. It seems best to explain why the reversion was performed, rather than simply reverting with no edit summary. At any rate, since you were offended, when removing unneeded entries from the page, I won't use the undo reversion function, and instead will manually remove the entry and leave the edit summary. That way, you and others won't be notified about the matter in the notifications area atop pages when logged in. North America1000 23:35, 4 June 2020 (UTC)
- Northamerica1000, that works for me. Thank you. – bradv🍁 23:38, 4 June 2020 (UTC)
- Just got this too. I think this would be a frequent error for people - the exceptions are buried kinda well. Advisory text in Twinkle would definitely be helpful. ProcrasinatingReader (talk) 00:29, 7 June 2020 (UTC)
- @Bradv: As I stated on my talk page, the edit summary I left is just a standard c/p that I use when removing unnecessary entries from the People delsort page. It was not meant to come across as any sort of lecture. It seems best to explain why the reversion was performed, rather than simply reverting with no edit summary. At any rate, since you were offended, when removing unneeded entries from the page, I won't use the undo reversion function, and instead will manually remove the entry and leave the edit summary. That way, you and others won't be notified about the matter in the notifications area atop pages when logged in. North America1000 23:35, 4 June 2020 (UTC)
I've opened a PR to do what I described above. ~ Amory (u • t • c) 18:27, 7 June 2020 (UTC)
Bumping thread for 20 days to prevent archiving, as this is still in the works.North America1000 14:13, 17 June 2020 (UTC)- Not sure what you mean — the changes I described above are now active. ~ Amory (u • t • c) 19:42, 17 June 2020 (UTC)
- Thanks. Struck the above and edited to remove the bump. North America1000 05:34, 18 June 2020 (UTC)
- Not sure what you mean — the changes I described above are now active. ~ Amory (u • t • c) 19:42, 17 June 2020 (UTC)
Restore this deleted version
Since the June 2020 TW update of adding rollback links to Special:RecentChanges and history pages, now TW truly feels like having the rollback user right. But there is also the restore this version button, and it shows up on every revision; every revision. It includes deleted revisions. Of course, you can't restore a deleted revision, but having a restore revision button on a deleted revision, it's unneccessary. REMOVE IT! {{reply to|Can I Log In}}'s talk page! 03:45, 18 June 2020 (UTC)
- Mmm, good point. Not sure you need boldly yell about it, but I opened a PR for history pages yesterday. ~ Amory (u • t • c) 11:19, 19 June 2020 (UTC)
- Can I Log In, "REMOVE IT!" please be a little nicer to your fellow volunteers —TheDJ (talk • contribs) 12:59, 19 June 2020 (UTC)
partial blocks?
Does Twinkle work for partial blocks? I just screwed one up because I didn't think it did but didn't want to use a full block. —valereee (talk) 19:02, 19 June 2020 (UTC)
- @Valereee: Yes, it does! It should be an unchecked box with the "Partial block" label in the usual Twinkle ARV interface. --qedk (t 愛 c) 19:39, 19 June 2020 (UTC)
- Yes, this (except it's block, not ARV ). ~ Amory (u • t • c) 19:54, 19 June 2020 (UTC)
- Oooops... --qedk (t 愛 c) 21:18, 19 June 2020 (UTC)
- QEDK, thank you! That'll with any luck keep me from making the same mistake twice. :) —valereee (talk) 19:56, 19 June 2020 (UTC)
- Gah, now I see it. Duh. —valereee (talk) 19:58, 19 June 2020 (UTC)
- Yes, this (except it's block, not ARV ). ~ Amory (u • t • c) 19:54, 19 June 2020 (UTC)
AfDing non-Article page
Hello! Quick suggestion - as fixing an incorrectly-issued-to-a-Talk-page AfD can be a bit of a pain (as I just found out!), would it be possible for Twinkle to display a quick 'Are you sure, you're about to trout yourself and feel very silly!' before you AFD a non-article page? (Or, if on an article Talk page, ask if you meant to AfD the associated article, as per my case?) OcarinaOfTime (talk) 18:49, 21 June 2020 (UTC)
What was that? 1234qwer1234qwer4 (talk) 18:22, 21 June 2020 (UTC)
- Good ol' fashioned bug! There's actually a few things going on here, I opened a PR to fix some of that behavior. The short version is Twinkle was only looking for a newline before pre-existing tags, not a bunch of spaces. ~ Amory (u • t • c) 19:18, 21 June 2020 (UTC)
Image hoax
Should {{Image hoax}} be listed by default on the image tags? It's a rather critical tag not not be a standard. {{Hoax}} is a standard for articles, so why not this? Adam9007 (talk) 18:47, 17 June 2020 (UTC)
- Seems reasonable to me? I'd welcome comments from folks who do more image-related work, but I would think it'd make sense. PR opened if anyone wants to chime in/review there. ~ Amory (u • t • c) 19:25, 21 June 2020 (UTC)
uw-vandalism1 template
The level 1 template for "Vandalism", {{uw-vandalism1}}
uses that term only in the name of the template and therefore in the HTML comment that it leaves with the name of the template in it upon substitution/transclusion. The language of the template as rendered to the reader uses the softer term "did not appear constructive".
I agree that this template is necessary and appropriate, and commonly use it for the not-necessarily-intentional-vandalism cases often committed by newbie editors. However, having the word "vandalism" in the name and description of the template in Twinkle, and (more importantly) visible in the source of the warning that is left for the user is inconsistent with the message, and the necessity to acknowledge the careful distiction between vandalism and other types of mistakes.
I propose that the level 1 vandalism template be moved to something like {{uw-unconstructive}}
, and the description in Twinkle be changed. It should possibly have a level 2 warning as well. (Pinging John from Idegon, who recently saw what wasn't there, except that it was. ) —[AlanM1 (talk)]— 07:25, 21 June 2020 (UTC)
- That's why I start with level 2. John from Idegon (talk) 07:41, 21 June 2020 (UTC)
- The problem, though, (as we've seen), is that a user leaving the level 1 template expects to leave an "unconstructive" note, but the summary contains the word vandalism, as does the source if the target looks at it. —[AlanM1 (talk)]— 13:02, 21 June 2020 (UTC)
- Support. We generally make quite a fuss when someone calls an edit "vandalism" when it isn't strictly vandalism; it makes no sense to use it the name of a template that is appropriate for unconstructive-but-not-necessarily-vandalism warnings. Schazjmd (talk) 14:33, 21 June 2020 (UTC)
- Oppose Level 1 uw templates are for AGF purposes, so {{uw-vandalism1}} would be used if it looks like vandalism but you have to AGF. Level 2 is assuming no faifth, so you would use that as an assume bad faith first warning. — Preceding unsigned comment added by Can I Log In (talk • contribs) 16:52, 21 June 2020 (UTC)
- Oppose - This is the wrong venue to suggest changes to individual warning templates,or the creation of new ones. That should be done at Wikipedia talk:Template index/User talk namespace. Twinkle is just a tool that uses preexisting notices and warnings. - BilCat (talk) 18:31, 21 June 2020 (UTC)
- Indeed. For what it's worth, Twinkle's edit summary is
General note: Unconstructive editing
, which makes no mention of the V-word. ~ Amory (u • t • c) 19:22, 21 June 2020 (UTC)- @Amorymeltzer: I (apparently mistakenly) assumed that the edit summary at Special:Diff/963585212 was from Twinkle because of the (TW) link and the following edit at Special:Diff/963585267 issuing the warning. The edit summary aside, the word still appears in the resulting warning (in the HTML comment of the template name). It's not clear which one resulted in the user being admonished, but I've seen it happen before, which is why I took the time to bring it up. @Bilcat: Thanks. I'll consider the other venue. —[AlanM1 (talk)]— 01:38, 22 June 2020 (UTC)
- Indeed. For what it's worth, Twinkle's edit summary is
The template {{BLP unsourced}} is currently under discussion
There is currently a discussion at Wikipedia:Templates for discussion/Log/2020 June 21 regarding a template part of the standard installation of Twinkle. The thread is Template:BLP unsourced. If the TfD results in delete, please remove this template from Twinkle. {{reply to|Can I Log In}}'s talk page! 03:28, 22 June 2020 (UTC)
Update to broken Vector menu for Twinkle — DEVS READ HERE
This is for folks from other projects who maintain their local forks of Twinkle who may be seeing broken Vector menus. A number of classes used by the Vector skin have been changed (see phab:T254797, phab:T254798, phab:T253329, and phab:T249372, among others), so the main Twinkle.js script to build that menu needs to change as well. MusikAnimal provided a good summary of the changes needed at phab:T254797#6230055, but specifically for changes, see the code at https://github.com/azatoth/twinkle/pull/962. In short:
- The selector in twinkle.css needs updating; I used
.vector-menu-dropdown
, MA used.vector-menu-content
(he's probably right) - Instead of
vectorMenu
, Vector needsvector-menu vector-menu-dropdown
for the dropdown - The check box hack needs
vector-menu-checkbox
rather thanvectorMenuCheckbox
- Appended to the dropdown is another div with
vector-menu-content
- The
ul
elements getvector-menu-content-list
I think the diff in the PR should be clear enough — it should fix a few other bugs. Be careful though, you probably dont't want to just copy paste the whole page unless your gadget has been recently updated, just those specific changes.
Feel free to ping me with any questions here, I'll try and answer as I can or am able to. ~ Amory (u • t • c) 01:31, 17 June 2020 (UTC)
- Hello Amorymeltzer, thanks for for the updating. But exactly what we should do in which css page for resolve this problem? Twinkle is using in Vietnamese Wikipedia, and we dont really know what things need to fix. Hoping for your help, thank you! --minhhuy (talk) 17:20, 17 June 2020 (UTC)
- Nevermind, we already fixed it
:)
--minhhuy (talk) 17:41, 17 June 2020 (UTC)
- Nevermind, we already fixed it
tewiki twinkle needs help
We are using Twinkle imported from enwiki around 2017-08-10, with minor fixes for maintenance subsequently. The recent vector menu changes had broken TW presentation to users. I have made the suggested changes specifically to te:Mediawiki:Vector.css and te:Mediawiki:Gadget-Twinkle.js (twAddPortlet()) function) but could not fix the error. TW menu disappeared altogether while the wikipedia searchbox is not aligned with the menu bar. RequestAmory or other experts to help. --Arjunaraoc (talk) 10:56, 19 June 2020 (UTC)
- Arjunaraoc, there are a few javascript errors in the latest version you've edited; you should be able to see some in your browser's console, but:
- Extra closing parenthesis on line 244
- Line 299 (
});
) is leftover/misplaced and can be removed
- Taking care of that should get you on the right foot. ~ Amory (u • t • c) 11:08, 19 June 2020 (UTC)
- My bad. I forgot to check js errors. Thanks Amory for your quick help. It is working now. --Arjunaraoc (talk) 11:48, 19 June 2020 (UTC)
Twinkle cs.wikipedia
I copied the twinkle here with Czech language translate. This tool from this page is used by multiple users (User:Kacir). Please fix the tool. Thank you. OJJ (talk) 06:53, 22 June 2020 (UTC)
- OJJ, You only made one change to the actual code. If meta:User:OJJ/twinkle-beta.js was working beforehand, you'll need to apply the changes seen here or summarized above. ~ Amory (u • t • c) 09:36, 22 June 2020 (UTC)
Underlinking
There have been some concerns expressed by an editor that AWB's auto-tagging is improperly adding {{underlinked}} to stub templates (samples here and here). Should the size of the article factor in to when the template should be added, and/or is there a way to avoid it being added to these articles? Is the tag being appropriately added? Primefac (talk) 15:41, 21 June 2020 (UTC)
- Does Twinkle do that too? - BilCat (talk) 19:11, 21 June 2020 (UTC)
- It's available in the tag module, the description is
needs more wikilinks to other articles
. ~ Amory (u • t • c) 19:19, 21 June 2020 (UTC)- Oh ffs, this was supposed to go at AWB's talk. Explains why there hasn't been any reply! Primefac (talk) 15:05, 22 June 2020 (UTC)
- It's available in the tag module, the description is
Proper sock sorting
Would it be possible to have ARV check the account creation dates on the master and socks and either warn the user that the master isn't the oldest account, or even better, just automagically reorder them to make it so. When mis-sorted SPI get generated, some poor clerk just has to fix it, so better to catch it earlier. Thanks. -- RoySmith (talk) 15:51, 20 June 2020 (UTC)
- +1, I thought about this before, would do it too if not for work. --qedk (t 愛 c) 17:06, 20 June 2020 (UTC)
- +1 Dreamy Jazz talk to me | my contributions 07:19, 21 June 2020 (UTC)
Created an issue to track, seems like it'd be helpful. ~ Amory (u • t • c) 19:48, 21 June 2020 (UTC)
- +1 Would be very, very helpful. --Jack Frost (talk) 08:34, 23 June 2020 (UTC)
Including the Uw-fringe set of templates
Can we add the Uw-fringe set of templates to the standard installation of Twinkle? SuperGoose007 (Honk!) 16:39, 24 June 2020 (UTC)
- There was a previous request that nobody else seemed interested in, fwiw. ~ Amory (u • t • c) 00:37, 26 June 2020 (UTC)
Is Twinkle able to place notices on the COI noticeboard?
The second question is "should it be able to?"
As a WP:AFC reviewer I'd like to be able to use Twinkle or a tool like it to make such reporting easier. Fiddle Faddle 11:15, 28 June 2020 (UTC)
- You mean like as another option in the ARV tool? ~ Amory (u • t • c) 01:33, 30 June 2020 (UTC)
Feature request: Allow merge nominations for pages in Project and Help spaces
See https://github.com/azatoth/twinkle/issues/1011. {{u|Sdkb}} talk 20:34, 29 June 2020 (UTC)
- WP:MfD if you must, just explain yourself in the summary. I don't have the link on-hand, but there was a discussion a little while ago about renaming MfD to ...for discussion (it comes up now and then); IIRC it was poorly attended but the general sense was that things that are MfD-eligible but not up for deletion should probably be discussed elsewhere.At any rate, Twinkle doesn't dictate policy; if you'd like to change MfD procedure, I'd head over to WT:MfD or WP:VPP. ~ Amory (u • t • c) 01:41, 30 June 2020 (UTC)
- Amorymeltzer, from my understanding, the proper way to propose Project and Help space merges is by tagging the pages with {{Merge from}} and {{Merge to}}, the same as is done for articles (you can see an example I just did earlier manually at WP:Wikipedians and WP:Who writes Wikipedia?). As you note, WP:MfD has "deletion" in the title, and unlike WP:TfD, the instructions refer exclusively to deletion rather than merging, so I would not think that would be the standard proper forum.
- So I'm not asking for any policy changes here, just that Twinkle introduce an option to automate the tagging process, the same way it offers assistance with tagging mainspace articles for merges. If I'm not missing something here, please re-open the request. {{u|Sdkb}} talk 03:32, 30 June 2020 (UTC)
- OOOOHHHH I get you know, sorry, totally misunderstood what you were asking for. From the GitHub issue:
There is currently no way (that I know of) to use Twinkle to nominate a Help: page or WP: page for merging with another page. (The article maintenance tags aren't available as they are for mainspace pages, and XfD doesn't have a merge component the way TfD does.) This is a significant issue, because there is extensive duplication of pages within those namespaces and pressing need to consolidate them; being able to easily propose a merge through Twinkle might help encourage that process.
- I thought you were asking for an XfD merge nomination à la TfD. No, you're asking for the tag module to be enabled on additional namespaces with a limited set of tags, in particular the various set of merge-like tags. Is that right? ~ Amory (u • t • c) 09:26, 30 June 2020 (UTC)
What does the rollback for Twinkle do?
I'm not sure if that rollback is different to WP:ROLLBACK, it probably is. But what is it used for and what does it do? User3749 (talk) 12:07, 3 July 2020 (UTC)
- User3749, a rollback in both cases reverts all edits by a single user, which is useful if vandalism or other issues occurred over multiple edits. Ed6767 talk! 12:53, 3 July 2020 (UTC)
@Ed6767 thanks! User3749 (talk) 12:55, 3 July 2020 (UTC)
Multi-page XfD nominations?
Is there a way to make multi-page XfD nominations with Twinkle? If not, can this be implemented? Adam9007 (talk) 19:14, 5 July 2020 (UTC)
- At the moment, no (to the first question). Primefac (talk) 23:52, 5 July 2020 (UTC)
Preview error
Is anyone else getting an error when previewing a welcome with Twinkle? Previewing the standard welcome gives Preview: error "error" occurred while contacting the API.
Actually adding the message works correctly. Certes (talk) 08:37, 3 July 2020 (UTC)
- Is this still ongoing, or have you seen this multiple times? I don't see any issues, so maybe there was a blip in connection? ~ Amory (u • t • c) 10:29, 6 July 2020 (UTC)
- @Amorymeltzer: I just checked and it's working for me again, so let's put this down to a transient fault at my end. Thanks for following up. Certes (talk) 10:59, 6 July 2020 (UTC)
Turn Twinkle links on Recent Changes as default?
Twinkle recently got the ability to add rollback/restore links to recent changes and history pages. Those were both off by default, but I wonder if folks think the links on Special:RecentChanges (and Special:RecentChangesLinked) should be on by default? When combined with the (also new, also off by default) rollback-in-place option for RC (and contributions), it's quite useful! So I'd like to solicit opinions here on both those questions: should links on Recent Changes be on by default, and should rollback-in-place on Recent Changes and Contributions be on by default? ~ Amory (u • t • c) 09:45, 7 July 2020 (UTC)
- I'm not too sure. I'd think that having them on by default would encourage people just not reviewing the edits and blindly clicking revert on good edits. Ed6767 talk! 12:12, 7 July 2020 (UTC)
- Thanks for mentioning these new features which I hadn't discovered. They look useful but probably shouldn't be on by default: it's too easy to misclick them when aiming for a (prev) difference etc. Certes (talk) 12:33, 7 July 2020 (UTC)
Twinkle in it:voy
In Italian Wikivoyage we had a "2012 version" that recently had some visual problems so I've tried to replace (almost completely) the old files:
- (previous) MediaWiki:Gadget-Twinkle.js
- (previous) MediaWiki:Gadget-morebits.js
- (previous) MediaWiki:Gadget-morebits.css
with the news ones:
- (current) MediaWiki:Gadget-Twinkle.js
- (current) MediaWiki:Gadget-morebits.js
- (current) MediaWiki:Gadget-morebits.css
but according to the users of this gadget it doesn't work anymore properly. Could you advise if I have to import other scripts, configuration or key missing pages?
Any suggestion would be highly appreciated (please ping me), --Andyrom75 (talk) 21:41, 1 July 2020 (UTC)
- Andyrom75, I'm literally running out the door and won't be around for a few days, so you've caught me at the worst time. Really quickly, though, were your issues related to the appearance of the menu in the Vector skin? If it started about two weeks ago, I bet so! Check out #Update to broken Vector menu for Twinkle — DEVS READ HERE on this page. If you revert to the last working version, and follow those instructions (basically, apply the changes found here), it should work.Beyond that, check those two versions of Twinkle.js; the reason your Twinkle isn't working right now is that the old version had all the individual files copied into one page, and the new version does not (you'll notice the size of the two versions is very different). Basically, there's no content right now! The Twinkle gadget was split into different files in 2013. As far as I can tell, there have basically been very few local changes since 2012, is that right? If true, that means that, beyond just the above tweak to fix the menus, you could easily update to the latest version. You'd have to install all the individual modules, and copy the gadget definition. It shouldn't be too hard, and I can tell you exactly what needs to be done, but just FYI there will be a lot of changes — lots has improved since 2012! If you'd like to do that, to start you off, you can read this and this. You can of course just import the en-wiki gadget files directly. ~ Amory (u • t • c) 09:42, 2 July 2020 (UTC)
- Amorymeltzer, thanks for your answer. I've tried to import manually all the script but the feedback I've received for a user is that is still doesn't work. Few more notes.
- I've copied completely the code of each script present in the list you provide me, without making any change in terms of configuration
- In MediaWiki:Gadget-Twinkle.js, I've applied the same changes done in the 2012 version (link to Wikivoyage instead of Wikipedia)
- In MediaWiki:Gadgets-definition I've NOT created the 3 hidden gadget but I have merged 3 of them into one leaving alone MediaWiki:Gadget-Twinkle-pagestyles.css with the request of activating jointly with the main Twinkle gadget. That's why I've preferred to not add other (currently) unused scripts to all the other users
- At your first convenience, could you suggest me the next steps to perform? Thanks, (please ping me) --Andyrom75 (talk) 07:19, 3 July 2020 (UTC)
- Andyrom75, I'm not entirely sure what you mean by not adding unused scripts to other users, since someone would have to enable the Twinkle gadget before the hidden gadgets would be loaded. Ignoring that, though, you need to change the order currently listed. morebits.js in particular must be loaded first (something like this) as even Twinkle.js needs it. ~ Amory (u • t • c) 10:26, 6 July 2020 (UTC)
- Amorymeltzer, I meant that an hidden gadget is loaded by default by any user (even unlogged ones), but since morebits is used just by Twinkle users (at least in it:voy) I would prefer (if possible) to limit its use.
- That said, as you suggested I've focused my attention to morebits and I've noticed a fact in it:voy:
- in voy:it:MediaWiki:Gadgets-definition morebits is present both in "dependencies=ext.gadget.morebits" (as before) and in the list of scripts to be loaded "morebits.js|morebits.css" (just added). Is it fine? Since I've moved morebits inside the script list (at the beginning as you suggested), should I remove the dependencies, right?
- In the affirmative case I would do the same for select2. --Andyrom75 (talk) 05:45, 7 July 2020 (UTC)
- Thankfully, it's not! A hidden gadget is just like any other: it's only loaded if the user explicitly selects it in their preferences, or you set it as a default gadget in the Gadgets-definition. As an example, in voy:it:MediaWiki:Gadgets-definition, look the definitions for HideCentralNotice (default) and HideSiteNotice (not default). You can check in your browser's console. With the default state,
mw.loader.moduleRegistry['ext.gadget.HideCentralNotice'].state
returns "ready" whilemw.loader.moduleRegistry['ext.gadget.HideSiteNotice'].state
returns "registered".As for the gadget definition, absolutely you should remove theext.gadget.morebits
andext.gadget.select2
! Those are probably causing the loading to fail, since it's requiring Twinkle to load a gadget that isn't present. ~ Amory (u • t • c) 09:43, 7 July 2020 (UTC)- I've removed the two "ext.gadget." as per your suggestion. Regarding the hidden gadgets let me highlight that a user cannot unselect them simply because they are hidden in their preferences :-) As you can see, I've used this option to load 4 block of scripts (pure js, desktop css, mobile css and mobile&desktop css) that must be always active for anyone. PS While I'm waiting for the feedback of a local Twinkle user, if you could proactively test Twinkle it would be great, so maybe we'll try to shorten the resolution time. Thanks, --Andyrom75 (talk) 16:00, 7 July 2020 (UTC)
- Amorymeltzer, finally something is moving! The user told me that appears the red vandalism label without the cop face (like before) and if clicking on restore it opens a discussion with the vandal while before a message was automatically sent. Is it what I've described the correct current behaviour? In the affirmative case it has been definitely solved. Please let me know, --Andyrom75 (talk) 17:51, 7 July 2020 (UTC)
- Well, I can't test it since I'm not autoconfirmed on it.wikivoyage, but it sounds like they were using the revert links and that sounds about right. Glad you've finally got it working! ~ Amory (u • t • c) 17:56, 7 July 2020 (UTC)
- This isn't particularly important, but, for what it's worth, the point of a hidden gadget is that it's something in the background. morebits.js is a library that can be used by other scripts or gadgets, and indeed it's used as such here by a few things. Twinkle should never be a hidden gadget, but morebits can be; if a user turns off Twinkle, they won't load the morebits gadget, so there should be no wasted loading.Similarly, you've also kept the Twinkle pagestyles peer unhidden, when probably that shouldn't be, especially since it's able for anyone to enable, even non-autoconfirmed users. ~ Amory (u • t • c) 17:58, 7 July 2020 (UTC)
- Amorymeltzer, last thing. With the exclusion of MediaWiki:Gadget-Twinkle.js where I've applied minor custom changes (e.g. WP->WV & English->Italian) all the other scripts are identical to the ones in en:wp. If you confirm that there's nothing to configure on them, I would substitute the content of those scripts in it:voy with
mw.loader.load('//en.wikipedia.org/w/index.php?title=.......&action=raw&ctype=text/javascript');
, to be be sure to use always the latest version. What do you think? - PS If you want I can give you the autoconfirm flag to test Twinkle. --Andyrom75 (talk) 08:07, 8 July 2020 (UTC)
- You can if you like! It obviously makes it harder to customize things — I imagine plenty of the stuff doesn't apply? — but it does ensure you'll stay up to date, code-wise. You'd have to watch out for things that change the gadget (like #946), things that require outside work (like #969), or changes to CSS where that won't work (like #971). ~ Amory (u • t • c) 19:22, 8 July 2020 (UTC)
- Amorymeltzer, last thing. With the exclusion of MediaWiki:Gadget-Twinkle.js where I've applied minor custom changes (e.g. WP->WV & English->Italian) all the other scripts are identical to the ones in en:wp. If you confirm that there's nothing to configure on them, I would substitute the content of those scripts in it:voy with
- Amorymeltzer, finally something is moving! The user told me that appears the red vandalism label without the cop face (like before) and if clicking on restore it opens a discussion with the vandal while before a message was automatically sent. Is it what I've described the correct current behaviour? In the affirmative case it has been definitely solved. Please let me know, --Andyrom75 (talk) 17:51, 7 July 2020 (UTC)
- I've removed the two "ext.gadget." as per your suggestion. Regarding the hidden gadgets let me highlight that a user cannot unselect them simply because they are hidden in their preferences :-) As you can see, I've used this option to load 4 block of scripts (pure js, desktop css, mobile css and mobile&desktop css) that must be always active for anyone. PS While I'm waiting for the feedback of a local Twinkle user, if you could proactively test Twinkle it would be great, so maybe we'll try to shorten the resolution time. Thanks, --Andyrom75 (talk) 16:00, 7 July 2020 (UTC)
- Thankfully, it's not! A hidden gadget is just like any other: it's only loaded if the user explicitly selects it in their preferences, or you set it as a default gadget in the Gadgets-definition. As an example, in voy:it:MediaWiki:Gadgets-definition, look the definitions for HideCentralNotice (default) and HideSiteNotice (not default). You can check in your browser's console. With the default state,
- Andyrom75, I'm not entirely sure what you mean by not adding unused scripts to other users, since someone would have to enable the Twinkle gadget before the hidden gadgets would be loaded. Ignoring that, though, you need to change the order currently listed. morebits.js in particular must be loaded first (something like this) as even Twinkle.js needs it. ~ Amory (u • t • c) 10:26, 6 July 2020 (UTC)
- Amorymeltzer, thanks for your answer. I've tried to import manually all the script but the feedback I've received for a user is that is still doesn't work. Few more notes.
Twinkle on Mobile
Good day everyone!
I'm currently enrolled in the Counter Vandalism Unit Academy under the tutelage of Cassiopeia. I am currently in the Tools section of the macadam program which requires the usage of Twinkle. As per the instructions Wikipedia:Twinkle/doc, I have already had it enabled but whenever I go to the Twinkle preferences, the instruction tells me to enable Twinkle, which I've already done. I have also done my fair share of reading on Twinkle, and the instructions are to the effect that it only works on desktop computers or laptops. I am editing on my mobile phone through a web browser. I would like to ask of it is possible for Twinkle to be used on mobile phones. Warmest regards Gardo Versace (talk) 00:26, 6 July 2020 (UTC)
- There should be a "request desktop site" option in your mobile browser which should allow you to use the desktop version of Wikipedia along with Twinkle. Galobtter (pingó mió) 00:36, 6 July 2020 (UTC)
- @Galobtter: Found it. Will be using it for the time being. But is there a way for me to use it on advanced mode setting? If not, will it be possible in the near future? Warmest regards Gardo Versace (talk) 14:55, 6 July 2020 (UTC)
- @Gardo Versace: Most scripts won't work in MobileFrontend because of the way it's built, there's not much Twinkle can do about this unfortunately. --qedk (t 愛 c) 18:45, 9 July 2020 (UTC)
- @Galobtter: Found it. Will be using it for the time being. But is there a way for me to use it on advanced mode setting? If not, will it be possible in the near future? Warmest regards Gardo Versace (talk) 14:55, 6 July 2020 (UTC)
- @QEDK: Sigh. Guess I'll just have to get used to using the desktop version of Wikipedia on my mobile phone. Thank you. Warmest regards. Gardo Versace (talk) 21:12, 9 July 2020 (UTC)
Enable features in Wikipedia:Sandbox
Hey. I wanted to test the tagging of articles in Wikipedia:Sandbox but twinkle's tag feature isn't available in non-article namespaces (I assume). Could this page be enabled as an exception? --Gonnym (talk) 18:13, 10 July 2020 (UTC)
- Gonnym, try Draft:Sandbox. Ionmars10 (talk) 20:36, 10 July 2020 (UTC)
- Thanks! Exactly what I needed. --Gonnym (talk) 20:38, 10 July 2020 (UTC)
Multiple sections for one month
Per discussion at WT:RedWarn#Talk page warning locations, when placing warnings on user talk pages Twinkle currently creates a new section for the month even if one already exists, if that section is not the last one on the page. This may be a bug as Twinkle notes "Info: No header for this month found, creating new one" or something along those lines. This also creates sections with duplicate titles and causes issues with RedWarn (which uses the first section instead of the second). Is this intentional/ideal (i.e., is the ball in your court, or (courtesy ping) Ed6767's)? LittlePuppers (talk) 02:02, 24 June 2020 (UTC)
- Recently came up at Wikipedia talk:Twinkle/Archive 42#Warn template bug? creating unneeded new section headers with minimal discussion; to quote myself, it's "intentional" in that
Twinkle only checks the last section on the page. It's been that way for a long time, I believe the idea is that once a different section has been created, it might be confusing or missed to put subsequent warnings above rather than below. Personally, I'm agnostic
. ~ Amory (u • t • c) 11:13, 24 June 2020 (UTC)- RedWarn is pretty new, but I'm curious, what does Huggle do? We might as well match them, I suppose. ~ Amory (u • t • c) 11:14, 24 June 2020 (UTC)
- I'm not sure, that's a good question - Petrb and Oshwah seem like reasonable people to ping who might know. LittlePuppers (talk) 15:25, 24 June 2020 (UTC)
- Weird. Twinkle is usually quite good at either locating the same section header it's trying to place and omitting doing so, or placing one if none exists. The only explanation is that another user left the previous section header manually or with a different automated tool that formatted the header differently than what Twinkle looks for. Twinkle then doesn't "find it", and proceeds to place a new one. Were the section headers formatted exactly the same? The spacing between the words and the =='s? The capitalization of the month? The spacing between the section header and body? The spacing between the header and the text above it? I'm obviously not sure which (if any) might cause this to happen, but to me, this is a possible cause... ~Oshwah~(talk) (contribs) 03:47, 11 July 2020 (UTC)
- Oshwah, I tested it by placing one warning on my talk page with Twinkle, creating a new section below it manually, and then placing another warning with Twinkle (no manual manipulation of Twinkle's heading). You can check it by going back a week or two on my talk page history. (Per Amory above apparently it's known behavior.) LittlePuppers (talk) 18:45, 12 July 2020 (UTC)
- Weird. Twinkle is usually quite good at either locating the same section header it's trying to place and omitting doing so, or placing one if none exists. The only explanation is that another user left the previous section header manually or with a different automated tool that formatted the header differently than what Twinkle looks for. Twinkle then doesn't "find it", and proceeds to place a new one. Were the section headers formatted exactly the same? The spacing between the words and the =='s? The capitalization of the month? The spacing between the section header and body? The spacing between the header and the text above it? I'm obviously not sure which (if any) might cause this to happen, but to me, this is a possible cause... ~Oshwah~(talk) (contribs) 03:47, 11 July 2020 (UTC)
- I'm not sure, that's a good question - Petrb and Oshwah seem like reasonable people to ping who might know. LittlePuppers (talk) 15:25, 24 June 2020 (UTC)
- RedWarn is pretty new, but I'm curious, what does Huggle do? We might as well match them, I suppose. ~ Amory (u • t • c) 11:14, 24 June 2020 (UTC)
Good article reassesments
(copied from WP:US/R) The process to nominate an article for good article reassessment is very time consuming and rather complicated (see the procedure laid out at Wikipedia:Good article reassessment), and I'd imagine that a script could automate this. Might be better as a twinkle feature— not sure—but here's my (with no coding experience) idea: an option to nominate it for individual or community reassessment, based upon what is selected the script will create the correct subpage. Then there could be a spot to type in the rationale and ideally the script would notify the original ga nominator and the original reviewer and any wikiprojects tagged on the talk. In my mind this would be like a combination of how twinkle handles XfD's and merge discussions, not sure how hard it would be to do, but as I anticipate nominating a lot of poor quality articles for reassessment soon, it could be very helpful. Best wishes, Eddie891 Talk Work 00:03, 26 June 2020 (UTC)
- @Eddie891: Done User:SD0001/GAR-helper. It's a twinkle-like but separate script. I have tested it. But please let me know of any issues/bugs if you come across any. SD0001 (talk) 20:41, 11 July 2020 (UTC)
- Notifying the original GA nominator and reviewer is not supported at the moment. Let me see if I can add that. Though I note that original nominator name doesn't seem to be available in an easily machine-readable form. SD0001 (talk) 20:45, 11 July 2020 (UTC)
- SD0001: thanks so much! I’ll try it out when I get to my computer Sunday night or Monday morning. Until then, best wishes — Eddie891 Talk Work 20:52, 11 July 2020 (UTC)
- SD0001, It's so far working very well for me! I would recommend leaving a note after the script has run in the box saying something like
The script has notified the the reviewer and page creator. Please consider manually notifying other involved editors and Wikiprojects with {{subst:GARMessage|ArticleName|GARpage=n}} ~~~~ OR {{subst:GARMessage|ArticleName|page=n}} ~~~~
Maybe the script could fill in that template too, to make copying and pasting easier. If that's too much work, don't worry, even this script is very helpful. Thanks again. Best wishes, Eddie891 Talk Work 17:43, 13 July 2020 (UTC)- Eddie891 done. 5 minutes job, acutally! SD0001 (talk) 19:05, 13 July 2020 (UTC)
Rationale for templatecat
Could you add a rationale field when adding {{db-templatecat}}? I more often then not find that I want to use it for a link to a relevant discussion. --Trialpears (talk) 07:28, 10 July 2020 (UTC)
- Not sure that would be useful, given that the template itself doesn't have a "reason" param (unless you're thinking of making it show up in the edit summary). Primefac (talk) 22:10, 10 July 2020 (UTC)
- Could have sworn it was implemented there. I'll add the option to the template if no one objects at Template talk:Db-meta#Adding rationale field to Template:db-templatecat. Still think it would be really useful. --Trialpears (talk) 22:29, 10 July 2020 (UTC)
- I suppose I do stand corrected, it hard-codes a reason parameter which is passed to {{db-g8}}, but a change would still need to be written and implemented. Primefac (talk) 22:54, 10 July 2020 (UTC)
- Could have sworn it was implemented there. I'll add the option to the template if no one objects at Template talk:Db-meta#Adding rationale field to Template:db-templatecat. Still think it would be really useful. --Trialpears (talk) 22:29, 10 July 2020 (UTC)
I've made the necessary template changes and a pull request at github. I haven't managed to figure out how to test it properly though. --Trialpears (talk) 19:51, 13 July 2020 (UTC)
- You're all good! ~ Amory (u • t • c) 12:14, 14 July 2020 (UTC)
Twinkle should check talk page for redirects before adding templates
I recently prodded an article that apparently had the talk page redirected to another article, but Twinkle followed the redirect added the prod template to the wrong article. I think it should check for redirects first before adding templates (this happened at Moonstone (comics)). --Piotr Konieczny aka Prokonsul Piotrus| reply here 01:32, 19 July 2020 (UTC)
Add Template:Uw-sigdesign to Twinkle's "Warn/Single-issue notices" function
...Just as the header states, can Template:Uw-sigdesign be added to Twinkle's "Warn/Single-issue notices" function? Asking since I've wanted/needed to use that template on new users' talk pages a few times now... Steel1943 (talk) 17:05, 15 July 2020 (UTC)
- @Steel1943: I assume you've already added it through your "Custom warning templates to display:" section of your Wikipedia:Twinkle/Preferences page, and simply feel it's useful for other users too? The way you worded the question made it seem like you hadn't. - BilCat (talk) 02:43, 19 July 2020 (UTC)
- @BilCat: Nope, I didn't even know the "Custom warning templates to display:" section existed until I read this message. But sure, let's go with stating this warning message should exist in Twinkle by default. 😉 Steel1943 (talk) 03:12, 19 July 2020 (UTC)
- Ah, ok. There are several custom fields in the Twinkle preferences, and they're very useful for warning, tags, etc. that aren't there already. I probably wouldn't use the warning you've suggested, but I wouldn't oppose it being added if other users found it useful. - BilCat (talk) 03:50, 19 July 2020 (UTC)
X2
Criteria X2 for content translation tool articles is being deprecated. I don't think twinkle supports X2 but since the template is tagged as used by twinkle I'll play it safe and drop a message here. --Trialpears (talk) 08:17, 19 July 2020 (UTC)
- Thanks and yup! I'm not sure if Twinkle ever did, tbh, but yeah, no issues here! ~ Amory (u • t • c) 10:20, 19 July 2020 (UTC)
Twinkle violating MOS:ORDER - needs correction
Please see this edit. In this edit, Twinkle put a {{Pp-blp}} tag above a {{Short description}} template, which is in violation of MOS:ORDER, since {{Short description}} is #1 and {{Pp-blp}} represents #3. Steel1943 (talk) 21:49, 23 June 2020 (UTC)
- Hi Steel1943, Unrelated to Twinkle but the date format script does the same thing, I've noticed tons of articles that have shortdesc either second or third as opposed to first,
- Would be nice if a bot could reorder these :), –Davey2010Talk 22:00, 23 June 2020 (UTC)
- @Davey2010: That edit you referenced ... wow, the date script put in a tag that is #5 on MOS:ORDER, but put the tag above both #1 and #4! Steel1943 (talk) 22:04, 23 June 2020 (UTC)
- Wow, That certainly is surprising, What's more surprising is that I didn't even know MOS:ORDER existed until now!, Anyway pinging Ohconfucius who may or may not be aware of MOS:ORDER, I've amended the order :), Thanks, –Davey2010Talk 22:16, 23 June 2020 (UTC)
- @Davey2010: That edit you referenced ... wow, the date script put in a tag that is #5 on MOS:ORDER, but put the tag above both #1 and #4! Steel1943 (talk) 22:04, 23 June 2020 (UTC)
- Yeah, Twinkle's not great about this. The tag module handles it pretty well, but the others (protect, xfd, prod, csd) don't pay much attention. In their defense, the whole short description thing is a pretty new phenomenon as far as Twinkle is concerned. I'll try and think about this when I get a chance. ~ Amory (u • t • c) 11:03, 24 June 2020 (UTC)
- Gave it a go for Twinkle: https://github.com/azatoth/twinkle/pull/1022 ~ Amory (u • t • c) 15:07, 6 July 2020 (UTC)
- Should be done now, for the most part anyway. ~ Amory (u • t • c) 15:46, 19 July 2020 (UTC)
Feature request: make template search easier to access
Wouldn't it be great if the warnings dialog that comes up first had a search box that was immediately visible? It's a waste of time to go through pull down menus to get to the templates search. ThatMontrealIP (talk) 20:11, 25 June 2020 (UTC)
- Sorry, I'm not really understanding what you're asking for. Are you saying you want the search box to be already selected when the menu loads? ~ Amory (u • t • c) 01:14, 27 June 2020 (UTC)
- @Amorymeltzer: yes, It would be great to be able to search all templates without the current process (having to click the template menu, then select all templates, then click another pull down and search in that box). I'm suggesting having a plain old search box that applies to all templates immediately visible. Maybe I am missing something but I always have to go through the above process to search all templates. For example I might think "ah, COi is where, oh ok it's under single-issue notices" then I click single issue notices, then I search for COI. It could instead be a single step with an immediately available search box. Am I doing it wrong?ThatMontrealIP (talk) 00:03, 30 June 2020 (UTC)
- Well, for starters, you can choose which dropdown group is the default option in your twinkle preferences. You can select all templates if you like. There's also an option to combine the two singlet menus, you can also choose that as your default, or indeed any of the others. Having it open with the cursor set in the search area is something to consider, though. I think I could support that. ~ Amory (u • t • c) 01:33, 30 June 2020 (UTC)
- @Amorymeltzer: Thanks for the quick reply and the tip! I like what you are saying about the cursor being immediateley in the all-template search.ThatMontrealIP (talk) 01:35, 30 June 2020 (UTC)
- Well, for starters, you can choose which dropdown group is the default option in your twinkle preferences. You can select all templates if you like. There's also an option to combine the two singlet menus, you can also choose that as your default, or indeed any of the others. Having it open with the cursor set in the search area is something to consider, though. I think I could support that. ~ Amory (u • t • c) 01:33, 30 June 2020 (UTC)
- @Amorymeltzer: yes, It would be great to be able to search all templates without the current process (having to click the template menu, then select all templates, then click another pull down and search in that box). I'm suggesting having a plain old search box that applies to all templates immediately visible. Maybe I am missing something but I always have to go through the above process to search all templates. For example I might think "ah, COi is where, oh ok it's under single-issue notices" then I click single issue notices, then I search for COI. It could instead be a single step with an immediately available search box. Am I doing it wrong?ThatMontrealIP (talk) 00:03, 30 June 2020 (UTC)
- I second this. It would be nice if the search box was above the dropdown rather than inside it. Nardog (talk) 16:33, 30 June 2020 (UTC)
Merged all files but not working in mlwiki
I have recently merged around 5 files related to Twinkle in mlwiki. At first, it showed an error 'morebitsWikiApiUserAgent is not a function', which was resolved by updating morebits.js file. As of now, Twinkle is showing errors: 'Uncaught TypeError: Twinkle[module] is not a function' and 'jQuery.Deferred exception: Twinkle[module] is not a function TypeError: Twinkle[module] is not a function'. I would like to know whether anybody have a solution to this problem. Adithyak1997 (talk) 05:41, 19 July 2020 (UTC)
- Adithyak1997, was everything working beforehand? I'll be honest, I wouldn't have thought that using
mw.loader.load
would work, and my quick tests suggest that indeed it doesn't. What's probably happening is that the Twinkle loading function from Twinkle.js is running before themw.loader.load
can pull in the source from enwiki, so you're ending up with an error. The enwiki pages are actually about to get updated today, which I think might solve that your issue; the order is likely to be different, but a quick test suggest it should work. You would have to update Twinkle.js as well as the Gadget definition, or you can just import the current versions locally. ~ Amory (u • t • c) 10:59, 19 July 2020 (UTC)- Everything didn't work good previously. There were many issues when using Twinkle but small functionalities like AfD worked correctly. Then came the issues related to Twinkle menu, which was resolved by Jayprakash12345. Problems like arv is not a function and fluff.init is not a function also existed which led me to take the post of an interface admin (temporary) there. Extra things created by me were addition of select2 and addition of pagestyles. Adithyak1997 (talk) 11:07, 19 July 2020 (UTC)
- Okay that makes sense. I'd be willing to bet that the only ones that worked were ones that were locally present (not loaded via importScript or mw.loader.load), is that, right? I'll ping you when I push the changes here if you like. ~ Amory (u • t • c) 11:13, 19 July 2020 (UTC)
- Adithyak1997, the section below has the new style of pages. If you update your Twinkle.js and Gadget (MediaWiki:Gadgets-definition), does that solve things? ~ Amory (u • t • c) 14:35, 20 July 2020 (UTC)
- Previously, I updated all the things to the main file. Inorder to avoid further issues, I have reverted all the merging. I will try creating all the required pages into my sandbox and will update as directed by you. Since I am a little busy now, I will try to update within a week. Adithyak1997 (talk) 14:43, 20 July 2020 (UTC)
- Everything didn't work good previously. There were many issues when using Twinkle but small functionalities like AfD worked correctly. Then came the issues related to Twinkle menu, which was resolved by Jayprakash12345. Problems like arv is not a function and fluff.init is not a function also existed which led me to take the post of an interface admin (temporary) there. Extra things created by me were addition of select2 and addition of pagestyles. Adithyak1997 (talk) 11:07, 19 July 2020 (UTC)
Why can't it be selected in the CSD menu? Could have used this a lot of times. --TheImaCow (talk • contribs) 18:40, 20 July 2020 (UTC)
- Because it's just another way to put G6? Primefac (talk) 21:59, 20 July 2020 (UTC)
Possible bug
Hello. This action resulted in User talk:95.56.108.95, where Twinkle replaced Hello, I'm Pyrite Pro...
at the top of Pyrite Pro's warning, with Hello, I'm DB1729...
. In fact, it did the same thing when WikiMacaroons issued a warning. --DB1729 (talk) 10:30, 23 July 2020 (UTC)
- DB1729, in both these cases, the UW templates weren't substituted as they should have been by Pyrite Pro as shown in the uw template documentation, so this issue occurred there and not with Twinkle as far as I can tell. You can even see a bot go round and fix this a bit too late in the page history. I've left Pyrite Pro a reminder. Ed6767 talk! 11:08, 23 July 2020 (UTC)
- OK. Thanks for the reply. --DB1729 (talk) 11:12, 23 July 2020 (UTC)
Add a block template please
There seems to be a level of agreement that failure to WP:ENGAGE is best handled by a partial block from article space, which is kinder than a sitewide block. I'd like to see a canned block with the following settings:
- Duration: Indefinite
- Log reason: Editing issues and failure to engage with the community
- Talk page rubric to include the fact that this block can be lifted as soon as the user begins engaging on article and user talk pages.
Thoughts? Guy (help!) 22:24, 21 July 2020 (UTC)
- @JzG: Probably the User warnings project is a better place for this, once it's made, we can add it to Twinkle. --qedk (t 愛 c) 20:02, 25 July 2020 (UTC)
Facing 2 issues
I know that I am using an outdated version. Still, there are 2 issues. Firstly, please check this edit. In that, the text 'ഒഴിവാക്കാൻ, ലയിപ്പിക്കാൻ, അഥവാ പുനഃനാമകരണം' (meaning delete, merge or rename) needs to show only one text. Now it's showing three. Secondly, 'വിക്കിപീഡിയ:ഒഴിവാക്കാൻ സാദ്ധ്യതയുള്ള ലേഖനങ്ങൾ' is the replacement for Wikipedia:Afd in mlwiki. The problem is, the summary appears correctly like the summary for this but the page doesn't contain the item, meaning, the deletion page is not getting posted in that. Adithyak1997 (talk) 18:48, 22 July 2020 (UTC)
- Adithyak1997, Regarding your first point, that's because the older version of xfd doesn't add the
action
parameter to the CfD notification template. I added that in this PR (specifically, this commit). I can't see the second link you posted, it's been deleted; sorry. ~ Amory (u • t • c) 16:01, 26 July 2020 (UTC)
"Unknown user" and rollback errors
Since changing some Twinkle options a few days ago, including setting "rollback in place" ([2]) I've been seeing "Reverted 1 edit by an unknown user" instead of the usual user name or IP, and rollback is only doing the first edit. See [3] yesterday and today for example. But it doesn't happen every time. Is there a fix for this? Thanks. --IamNotU (talk) 15:47, 25 July 2020 (UTC)
- That's definitely a bug IamNotU, thanks for the report! Do you remember where you clicked on the links from? Diff, history, contributions, that sort of thing? ~ Amory (u • t • c) 15:38, 26 July 2020 (UTC)
- I don't remember, sorry. I'll try to keep an eye on it and get back to you. --IamNotU (talk) 15:41, 26 July 2020 (UTC)
- Amorymeltzer, it just happened again, I was on this page: Special:Contributions/2601:199:4180:F670:542F:E131:AC1F:E73B/64 and I made this revert using Twinkle's "rollback" link. I got the small popup box on the right for the "rollback in place". Maybe it's related to this being the page for an IP range (/64) and not a single IP? But it's also related to one of the changes I made in the preferences, because it always worked before. I'll try to go find some more edits to revert... --IamNotU (talk) 21:47, 26 July 2020 (UTC)
- @IamNotU: Yup, that's definitely an issue, if not the issue! I know you said you didn't recall where you clicked previously, but, if they were contributions, would they also have been on the /64? ~ Amory (u • t • c) 09:58, 27 July 2020 (UTC)
- IamNotU, I just pushed a fix that should take care of it when being run from an IP range's contributions page. It will take a few minutes to go through (and you might need to clear your cache), but let me know if you still see anything, or if you think you ever saw it from somewhere other than IP range contributions page. ~ Amory (u • t • c) 10:39, 27 July 2020 (UTC)
- Seems to be working now, thanks! The other times were all IPV6s, so it's likely I was on a /64 page, which I do often but not always. Also I'm not sure anymore that it was related to changing my prefs, because it looks like it happened also the day before I did that. Maybe just a coincidence. PS, is it possible somehow to get the AGF/rollback/vandalism links to show on an article's history page and/or my watchlist too? I use a "live diffs" script so I don't have to click on the diff link, so it would be great if I could just do everything without leaving the page. I know I can do it with "real" rollback, but I haven't found a good solution to make proper edit summaries that way. Thanks again... --IamNotU (talk) 19:26, 27 July 2020 (UTC)
- It wasn't, so no worries on your end. I changed the way the various links are created, unifying a lot of code that was largely duplicated, and then separately put in a system to handle cases where usernames were revision deleted (rare, but possible). In doing the latter, I didn't account for the fact that Twinkle uses a little hack to enable itself on IP range contribution pages and failed to provide the correct usernames for each link.You can enable rollback links on history pages in your Twinkle prefs, at the very end of the revert and rollback section. Twinkle has never been activated on the watchlist, mainly to avoid further slowing down an already-slow page. ~ Amory (u • t • c) 19:44, 27 July 2020 (UTC)
- Ok, thanks for taking care of it. Don't know how I missed that checkbox for history pages before. It still would be really nice to have it on my watchlist though. If I could do "live diffs" and "rollback in place" direct from the watchlist, I think it would more than make up for any slowness in loading it. Maybe you'll have time to add it someday... --IamNotU (talk) 20:33, 27 July 2020 (UTC)
- It wasn't, so no worries on your end. I changed the way the various links are created, unifying a lot of code that was largely duplicated, and then separately put in a system to handle cases where usernames were revision deleted (rare, but possible). In doing the latter, I didn't account for the fact that Twinkle uses a little hack to enable itself on IP range contribution pages and failed to provide the correct usernames for each link.You can enable rollback links on history pages in your Twinkle prefs, at the very end of the revert and rollback section. Twinkle has never been activated on the watchlist, mainly to avoid further slowing down an already-slow page. ~ Amory (u • t • c) 19:44, 27 July 2020 (UTC)
- Seems to be working now, thanks! The other times were all IPV6s, so it's likely I was on a /64 page, which I do often but not always. Also I'm not sure anymore that it was related to changing my prefs, because it looks like it happened also the day before I did that. Maybe just a coincidence. PS, is it possible somehow to get the AGF/rollback/vandalism links to show on an article's history page and/or my watchlist too? I use a "live diffs" script so I don't have to click on the diff link, so it would be great if I could just do everything without leaving the page. I know I can do it with "real" rollback, but I haven't found a good solution to make proper edit summaries that way. Thanks again... --IamNotU (talk) 19:26, 27 July 2020 (UTC)
- IamNotU, I just pushed a fix that should take care of it when being run from an IP range's contributions page. It will take a few minutes to go through (and you might need to clear your cache), but let me know if you still see anything, or if you think you ever saw it from somewhere other than IP range contributions page. ~ Amory (u • t • c) 10:39, 27 July 2020 (UTC)
- @IamNotU: Yup, that's definitely an issue, if not the issue! I know you said you didn't recall where you clicked previously, but, if they were contributions, would they also have been on the /64? ~ Amory (u • t • c) 09:58, 27 July 2020 (UTC)
Posted at VPT
For those interested, I plan on using tags to identify Twinkle edits and actions rather than the current add-to-editsummary method. I posted about it WP:VPT. ~ Amory (u • t • c) 19:27, 29 July 2020 (UTC)
July 2020 Twinkle updates, features, and behaviors (2020-07-19) @2b6f9a7
A lot of bug fixes this time around, as well as some major refactoring on the backend thanks to SD0001. Some of the more notable improvements are a massive increase in the number of redirect tags available, automatic selection of the template menu in the warning menu, and a ton of fixes to endorsing PRODs. There are a number of other improvements and bug fixes; a brief summary of some of them are below. Changes not otherwise attributed were made by User:Amorymeltzer.
- Multiple:
- Respect MOS:ORDER for hatnotes and shortdesc in PROD, CSD, XfD, tag, and protect modules (#1022)
- Also updates the list of hatnote templates Twinkle watches out for
- Don't follow cross-namespace redirects when notifying users (PROD, XfD, CSD, warn, block) (#915, by SD0001) (see also #1017 and #1016)
- Bold action completed messages (#1038, by SD0001)
- Better display of long numbers (#988, by Huji)
- Respect MOS:ORDER for hatnotes and shortdesc in PROD, CSD, XfD, tag, and protect modules (#1022)
- tag:
- speedy:
- Remove T2 (#1043)
- Add rationale field for {{db-templatecat}} (#1042, by Trialpears)
- prod:
- warn:
- Automatically focus on the template selection menu (#1023)
- Add outing to uw-pinfo label to aid in searching (#1031) (#1024, by JJMC89)
- Fix a couple bugs in custom warning edit summaries (#1026)
- Fix bug in autolevel not elevating level for singlewarn (#1028)
- Fix bug where autolevel message wouldn't display (#1014)
- revert and rollback:
- xfd: Fix xfd log numbering (#981) (#977, by Mdaniels5757)
- block:
- unlink: Alert/return if no pages selected, show more accurate interface message (#998)
This section should serve as a catching ground should anything not work properly or if any new bugs crop up, as well as for any feedback or suggestions. There were a lot of changes behind the scenes, so feel free to ping me. As always, input is welcome at the GitHub repo as well. Finally, if you're interested in helping out with Twinkle development, there's a guideline to help new contributors get set up — check it out! ~ Amory (u • t • c) 15:43, 19 July 2020 (UTC)
- Is anyone else no longer seeing the ability to issue user warnings to their Talk pages? DonIago (talk) 15:44, 19 July 2020 (UTC)
- @Doniago: Give it a few minutes: when the gadget pages get updated, it takes a few minutes for the ResourceLoader to field the new files. I think it should be all clear now, so let me know if it's still an issue (quick test worked for me). ~ Amory (u • t • c) 15:50, 19 July 2020 (UTC)
- Looks good now! Just a timing issue. :) Thanks! DonIago (talk) 16:04, 19 July 2020 (UTC)
- @Doniago: Give it a few minutes: when the gadget pages get updated, it takes a few minutes for the ResourceLoader to field the new files. I think it should be all clear now, so let me know if it's still an issue (quick test worked for me). ~ Amory (u • t • c) 15:50, 19 July 2020 (UTC)
Issues with tagging (consolidated)
@GSS, ProcrastinatingReader, LaundryPizza03, Steel1943, Chris troutman, Timtrent, and Grey Wanderer: Sorry for all the issues you (and presumably others) are facing. I've consolidated the sections here, and put up a tracking issue on GitHub, to try and organize some thoughts. I've now reverted all of the changes made recently (with one notable exception) so do please let me know whether you are or aren't still seeing the same issues (you may have to refresh your cache). For those of you who can load checkboxes, can you check what happens if you open, close, then open again the tag module? I can't replicate any of the issues anymore so I'll take any reports, details, error messages, anything! Really sorry for all the hassle. ~ Amory (u • t • c) 17:24, 25 July 2020 (UTC)
- It's working fine for me now, on all articles. I've checked on some with existing tags, some without, including the list I added earlier in this section. Sorry, I'm not sure what you mean by
what happens if you open, close, then open again the tag module
-- it behaves as expected, I suppose? No debug messages in console or anything, if that's what you meant? ProcrastinatingReader (talk) 17:29, 25 July 2020 (UTC)- That's indeed what I meant, thank you. ~ Amory (u • t • c) 17:40, 25 July 2020 (UTC)
- Thank you for your efforts Amorymeltzer, I tried on Apollo 11 and a few others and it's now working perfectly. GSS 💬 17:29, 25 July 2020 (UTC)
- Amorymeltzer, Only had a chance to check it once. Put a single cleanup tag on with success. Good luck with finding the issue when you roll the changes 'back' forwards! You can bet it'll be obvious and hiding in plain sight Fiddle Faddle 19:06, 25 July 2020 (UTC)
Just FYI to all, I restored the changes (with the fixes) a little over an hour ago. Let me know if any issues arise or persist, you may need to clear your cache. ~ Amory (u • t • c) 19:22, 26 July 2020 (UTC)
Error on tag
When I click "Tag" I now see an empty list (no checkboxes), on all articles. Browser console has: Uncaught TypeError: Cannot read property 'indexOf' of null
at this line: https://github.com/azatoth/twinkle/blob/master/modules/friendlytag.js#L560
ProcrastinatingReader (talk) 18:52, 19 July 2020 (UTC)
- ProcrastinatingReader, Works for me. Adam9007 (talk) 19:34, 19 July 2020 (UTC)
- Facing the same issue since last night. GSS 💬 07:53, 20 July 2020 (UTC)
- @ProcrastinatingReader and GSS: Do either or both of you still see this issue? I suspect there was a timing/caching issue. If you do still see the error, what page and what tags were you trying? ~ Amory (u • t • c) 14:33, 20 July 2020 (UTC)
- Amorymeltzer, I do. It happens on any page, and no tag in particular, I just can't see any tags. Looks like this: https://i.imgur.com/2q5egsQ.png (that was at Apollo 11) ProcrastinatingReader (talk) 23:24, 20 July 2020 (UTC)
- Can you replicate it and show any errors that you see in your browser console (see WP:JSERROR)? And, if you don't mind, what browser are you using? ~ Amory (u • t • c) 00:16, 21 July 2020 (UTC)
- Amorymeltzer, sorry I'm not sure what you mean by replicate (as in reproduce? if so, yes, this happens to me on every article)
- The error is in my original message, the line it refers to is that highlighted line (L 560) in friendlytag.js. Here's a full trace:
- ProcrastinatingReader (talk) 00:22, 21 July 2020 (UTC)
::::::Uncaught TypeError: Cannot read property 'indexOf' of null :::::: at makeCheckbox (load.php?lang=en&modules=ext.gadget.Twinkle&skin=vector&version=80fli:376) :::::: at Object.<anonymous> (load.php?lang=en&modules=ext.gadget.Twinkle&skin=vector&version=80fli:383) :::::: at Function.each (load.php?lang=en&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets|jquery.ui&skin=vector&version=1rtpe:5) :::::: at doCategoryCheckboxes (load.php?lang=en&modules=ext.gadget.Twinkle&skin=vector&version=80fli:383) :::::: at Array.<anonymous> (load.php?lang=en&modules=ext.gadget.Twinkle&skin=vector&version=80fli:384) :::::: at Function.each (load.php?lang=en&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets|jquery.ui&skin=vector&version=1rtpe:5) :::::: at Object.<anonymous> (load.php?lang=en&modules=ext.gadget.Twinkle&skin=vector&version=80fli:384) :::::: at Function.each (load.php?lang=en&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets|jquery.ui&skin=vector&version=1rtpe:5) :::::: at HTMLSelectElement.Twinkle.tag.updateSortOrder (load.php?lang=en&modules=ext.gadget.Twinkle&skin=vector&version=80fli:383) :::::: at friendlytagCallback (load.php?lang=en&modules=ext.gadget.Twinkle&skin=vector&version=80fli:376) ::::::
- Thanks, I'll try and look into this — I can't replicate it in any of chrome/firefox/safari on my end, so I'll do what I can. ~ Amory (u • t • c) 00:33, 21 July 2020 (UTC)
- Can you replicate it and show any errors that you see in your browser console (see WP:JSERROR)? And, if you don't mind, what browser are you using? ~ Amory (u • t • c) 00:16, 21 July 2020 (UTC)
- Amorymeltzer, I do. It happens on any page, and no tag in particular, I just can't see any tags. Looks like this: https://i.imgur.com/2q5egsQ.png (that was at Apollo 11) ProcrastinatingReader (talk) 23:24, 20 July 2020 (UTC)
- @ProcrastinatingReader and GSS: Do either or both of you still see this issue? I suspect there was a timing/caching issue. If you do still see the error, what page and what tags were you trying? ~ Amory (u • t • c) 14:33, 20 July 2020 (UTC)
- Facing the same issue since last night. GSS 💬 07:53, 20 July 2020 (UTC)
- @Amorymeltzer: I do, but not on every page. It's working perfectly fine on Indian nationality law and Draft:Ali Al Tantawi, but not on TietoEVRY and Web analytics. I see the same error as this. GSS 💬 12:25, 21 July 2020 (UTC)
Uncaught TypeError: Cannot read property 'indexOf' of null at makeCheckbox (load.php?lang=en&modules=ext.gadget.Navigation_popups%2CTwinkle&skin=vector&version=11zsw:542) at Object.<anonymous> (load.php?lang=en&modules=ext.gadget.Navigation_popups%2CTwinkle&skin=vector&version=11zsw:549) at Function.each (load.php?lang=en&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets|jquery.ui&skin=vector&version=1rtpe:5) at doCategoryCheckboxes (load.php?lang=en&modules=ext.gadget.Navigation_popups%2CTwinkle&skin=vector&version=11zsw:549) at Array.<anonymous> (load.php?lang=en&modules=ext.gadget.Navigation_popups%2CTwinkle&skin=vector&version=11zsw:550) at Function.each (load.php?lang=en&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets|jquery.ui&skin=vector&version=1rtpe:5) at Object.<anonymous> (load.php?lang=en&modules=ext.gadget.Navigation_popups%2CTwinkle&skin=vector&version=11zsw:550) at Function.each (load.php?lang=en&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets|jquery.ui&skin=vector&version=1rtpe:5) at HTMLSelectElement.Twinkle.tag.updateSortOrder (load.php?lang=en&modules=ext.gadget.Navigation_popups%2CTwinkle&skin=vector&version=11zsw:549) at friendlytagCallback (load.php?lang=en&modules=ext.gadget.Navigation_popups%2CTwinkle&skin=vector&version=11zsw:542) MoreMenu.messages.en.js:1 Failed to load resource: net::ERR_CONNECTION_REFUSED MoreMenu.user.js:1 Failed to load resource: net::ERR_CONNECTION_REFUSED MoreMenu.page.js:1 Failed to load resource: net::ERR_CONNECTION_REFUSED MoreMenu.js:1 Failed to load resource: net::ERR_CONNECTION_REFUSED
- and this is what errors I see at Apollo 11. GSS 💬 12:45, 21 July 2020 (UTC)
- @GSS: I strongly believe it's an issue on your side. From the last 4 lines of your latest comment, I think its an issue with your network connection. Please check whether you can reproduce the same when using some other internet connection. Sorry if my reply is unrelated. Adithyak1997 (talk) 13:16, 21 July 2020 (UTC)
- In this case it's not related, but it's certainly something weird going on that could be exacerbating any issues for sure! ~ Amory (u • t • c) 13:54, 21 July 2020 (UTC)
- @GSS: Okay I could replicate it on TietoEVRY, so this was super helpful, thanks! I've just pushed a fix (sorry, delayed by ancient laptop + yogurt explosion, thankfully not together), should take effect within a minute or two. ~ Amory (u • t • c) 13:53, 21 July 2020 (UTC)
- Amorymeltzer, issues are persisting for me. eg at Barbra Streisand. I'm getting exactly the same issue as before. ProcrastinatingReader (talk) 13:52, 23 July 2020 (UTC)
- All good now, it looks like! Maybe just caches or something delayed the fix for me. -- thanks for the patch :) ProcrastinatingReader (talk) 09:54, 24 July 2020 (UTC)
- Amorymeltzer, hmm. I'm testing on my other Mac (using Chrome) and I still get the issue. I assume the patch was this. I've hard flushed my caches and ensured this is the version being loaded in Chrome, but I still get the error. On Safari, I don't get any error. Hence, I'm thinking some kind of cache error, but since the version of the file on my end matches with the update I'm not sure it'd be that. Any suggestions? ProcrastinatingReader (talk) 16:11, 24 July 2020 (UTC)
- ProcrastinatingReader, well, if you're not sure and were still seeing it (before about an hour ago), you could try copying the text of that revision and pasting it into your browser console. That should create a new tag menu button, and clicking on that would be a way of testing the exact version. ~ Amory (u • t • c) 17:33, 25 July 2020 (UTC)
- Amorymeltzer, hmm. I'm testing on my other Mac (using Chrome) and I still get the issue. I assume the patch was this. I've hard flushed my caches and ensured this is the version being loaded in Chrome, but I still get the error. On Safari, I don't get any error. Hence, I'm thinking some kind of cache error, but since the version of the file on my end matches with the update I'm not sure it'd be that. Any suggestions? ProcrastinatingReader (talk) 16:11, 24 July 2020 (UTC)
- All good now, it looks like! Maybe just caches or something delayed the fix for me. -- thanks for the patch :) ProcrastinatingReader (talk) 09:54, 24 July 2020 (UTC)
- Amorymeltzer, issues are persisting for me. eg at Barbra Streisand. I'm getting exactly the same issue as before. ProcrastinatingReader (talk) 13:52, 23 July 2020 (UTC)
- @GSS: I strongly believe it's an issue on your side. From the last 4 lines of your latest comment, I think its an issue with your network connection. Please check whether you can reproduce the same when using some other internet connection. Sorry if my reply is unrelated. Adithyak1997 (talk) 13:16, 21 July 2020 (UTC)
Bug report: Duplicate tags
When I used Twinkle to tag an article that already had a tag at the beginning and wrap them in {{Multiple issues}}, it added each of the new tags twice (Special:Diff/968926473). –LaundryPizza03 (dc̄) 10:25, 22 July 2020 (UTC)
- This also happened to me here: Special:Diff/968980131; the tag was not on the article already, but Twinkle added the tag twice. Steel1943 (talk) 17:40, 22 July 2020 (UTC)
- I've encountered this problem twice today. Chris Troutman (talk) 19:00, 22 July 2020 (UTC)
- That's no good. I've been a bit busy so haven't been able to test too deeply, but I can't seem to replicate this. I'll try and look a little deeper tonight or tomorrow when I get a moment, but what browsers are you folks using? (steel IIRC you're on ff?) ~ Amory (u • t • c) 13:00, 23 July 2020 (UTC)
- I'm on Chrome. The error only happens when the "multiple issues" box is checked, even if they were already present. Chris Troutman (talk) 13:30, 23 July 2020 (UTC)
- In my example above, I didn't check the "multiple issues" box, and still had duplicate tags put on the article. Steel1943 (talk) 15:14, 23 July 2020 (UTC)
- Amorymeltzer, Mac and Safari. Happens repeatably for me when the MI box is checked. Fiddle Faddle 15:09, 23 July 2020 (UTC)
- I'm on Chrome. The error only happens when the "multiple issues" box is checked, even if they were already present. Chris Troutman (talk) 13:30, 23 July 2020 (UTC)
- It has been happening to me for weeks. Using safari. Grey Wanderer (talk) 00:47, 24 July 2020 (UTC)
- Grey Wanderer, how sure are you about weeks? That's an interesting point not noted above, which could help me narrow things down. Do you have a diff of it happening before July 19th? ~ Amory (u • t • c) 01:19, 24 July 2020 (UTC)
- My memory must be suspect. Indeed the oldest diff I can find is on July 19th. Grey Wanderer (talk) 02:18, 24 July 2020 (UTC)
- Grey Wanderer, how sure are you about weeks? That's an interesting point not noted above, which could help me narrow things down. Do you have a diff of it happening before July 19th? ~ Amory (u • t • c) 01:19, 24 July 2020 (UTC)
- ...Still happening, and I unchecked the {{Multiple issues}} tag prior to tagging the article since it was only one tag. Steel1943 (talk) 18:10, 24 July 2020 (UTC)
- I tagged an article with a single improve categories tags. It created its own MI box and popped two inside. Fiddle Faddle 18:41, 24 July 2020 (UTC)
- I don't have any time in the coming weeks to look at these issues (this one and the one in #Error on tag). Amorymeltzer, does the same apply to you? If so, we should rollback Mediawiki:Gadget-friendlytag.js to the last stable version, and tackle the issues later on github. SD0001 (talk) 11:10, 25 July 2020 (UTC)
- Yeah, that's my intent once I get back to a machine (approx 4 hours). I'll set aside some time today and tomorrow to try and look at these (means I won't be doing reviews...) but I can't replicate any of 'em anymore so it'll be difficult (race?). — Preceding unsigned comment added by Amory (talk • contribs) 11:31, 25 July 2020 (UTC)
Okay so I think I figured this one out! It looks like my solution for welcoming on IE 11 issue below should take care of it. So that's one down for now... ~ Amory (u • t • c) 19:07, 25 July 2020 (UTC)
Can't welcome with IE
Since the latest update, I can't issue welcomes when using Internet Explorer. Attempts to do so just produce {{subst:undefined}}
and my signature. (Everything else, including issuing warnings, seems to work fine.) Now, I realize that fixing this might be low priority, given IE's status. I use other browsers for other purposes, but for what I do on Wikipedia, IE is by far my preferred browser. Is there anything that can be done? Thanks, MANdARAX • XAЯAbИAM 08:10, 22 July 2020 (UTC)
- I see you've been testing, but can you try again with IE and paste the output from your browser console? That'd be helpful. I assume the preview doesn't work either? Also, what version of IE are you using? ~ Amory (u • t • c) 09:55, 22 July 2020 (UTC)
- You assume correctly that the preview doesn't work. I've got IE 11.959.18362.0.
Console
|
---|
Go to page: DOM7011: The code on this page disabled back and forward caching. For more information, see: http://go.microsoft.com/fwlink/?LinkID=291337 User_talk:Sandbox_for_user_warnings HTML1300: Navigation occurred. User_talk:Sandbox_for_user_warnings JQMIGRATE: Migrate is installed with logging active, version 3.1.0 This page is using the deprecated ResourceLoader module "jquery.tipsy". This page is using the deprecated ResourceLoader module "jquery.ui". Please use OOUI instead. JQMIGRATE: jQuery.fn.delegate() is deprecated Click on welcome tab: JQMIGRATE: jQuery.fn.bind() is deprecated JQMIGRATE: jQuery.fn.unbind() is deprecated JQMIGRATE: jQuery.isWindow() is deprecated JQMIGRATE: jQuery.fn.offset() requires a valid DOM element Submit: JQMIGRATE: jQuery.fn.andSelf() is deprecated and removed, use jQuery.fn.addBack() |
- Thanks for looking into this. MANdARAX • XAЯAbИAM 07:44, 23 July 2020 (UTC)
- Okay woof. Took me a while but I figured it out. Opened a PR which should take care of it I think. Hard to test on IE! ~ Amory (u • t • c) 12:52, 23 July 2020 (UTC)
- Yep, it works now. Sorry it was so difficult. Thank you very much for going to the effort! MANdARAX • XAЯAbИAM 17:47, 23 July 2020 (UTC)
- Mandarax, Wait, it works? I didn't push the change live to Wikipedia yet, so if it started working... ~ Amory (u • t • c) 01:18, 24 July 2020 (UTC)
- Well, I just tried again, and it doesn't work. So the one that did work was either some bizarre fluke, or, more likely, I may have absentmindedly tried it from an iPad. Sorry I don't remember. (In my defense, I got very little sleep.) MANdARAX • XAЯAbИAM 02:57, 24 July 2020 (UTC)
- Mandarax, thanks for that update. Sorry for not pushing the fix for this yet; the fix for this could have affected other modules, and given all the issues above with tagging, I didn't want to mix up any reporting. It looks like this also solved one of the related tag issues above, so I'll push this live now to fix your issue. Let me know if you see any additional funkiness... ~ Amory (u • t • c) 19:10, 25 July 2020 (UTC)
- It works! (And, yes, this time I definitely used IE.) No need to apologize for the delay: 1) it's for a browser that's not in wide use, and 2) I could still welcome people using other browsers (or manually). Once again, thank you very much – not just for this, but for everything you do around here! MANdARAX • XAЯAbИAM 20:45, 25 July 2020 (UTC)
- Mandarax, thanks for that update. Sorry for not pushing the fix for this yet; the fix for this could have affected other modules, and given all the issues above with tagging, I didn't want to mix up any reporting. It looks like this also solved one of the related tag issues above, so I'll push this live now to fix your issue. Let me know if you see any additional funkiness... ~ Amory (u • t • c) 19:10, 25 July 2020 (UTC)
- Well, I just tried again, and it doesn't work. So the one that did work was either some bizarre fluke, or, more likely, I may have absentmindedly tried it from an iPad. Sorry I don't remember. (In my defense, I got very little sleep.) MANdARAX • XAЯAbИAM 02:57, 24 July 2020 (UTC)
- Mandarax, Wait, it works? I didn't push the change live to Wikipedia yet, so if it started working... ~ Amory (u • t • c) 01:18, 24 July 2020 (UTC)
- Yep, it works now. Sorry it was so difficult. Thank you very much for going to the effort! MANdARAX • XAЯAbИAM 17:47, 23 July 2020 (UTC)
- Okay woof. Took me a while but I figured it out. Opened a PR which should take care of it I think. Hard to test on IE! ~ Amory (u • t • c) 12:52, 23 July 2020 (UTC)
- Thanks for looking into this. MANdARAX • XAЯAbИAM 07:44, 23 July 2020 (UTC)
- I'm having similar issue and I keep forgetting to come here and mention it.[4] It's only when I welcome from a diff, doing it directly from their talk page still works fine so it's not a huge deal. I'm using Chrome 83.0.4103.119. (actually when I went to check the version it said I needed an update so as of right now I'm using 84.0.4147.94) Beeblebrox (talk) 23:26, 31 July 2020 (UTC)
- Well crap, since that update it is now working very, very slowly. Beeblebrox (talk) 23:46, 31 July 2020 (UTC)
- this was apparently a side effect of the update, which also signed me out of absolutely everything, so forget that part of it. Beeblebrox (talk) 01:08, 1 August 2020 (UTC)
- Thanks for the report, yup! Just posted a fix, should be taken care of now! ~ Amory (u • t • c) 09:58, 1 August 2020 (UTC)
- Just tested it, works fine now. Thanks! Beeblebrox (talk) 18:29, 1 August 2020 (UTC)
- Thanks for the report, yup! Just posted a fix, should be taken care of now! ~ Amory (u • t • c) 09:58, 1 August 2020 (UTC)
- this was apparently a side effect of the update, which also signed me out of absolutely everything, so forget that part of it. Beeblebrox (talk) 01:08, 1 August 2020 (UTC)
- Well crap, since that update it is now working very, very slowly. Beeblebrox (talk) 23:46, 31 July 2020 (UTC)
Technical changes
For maintainers of other projects be aware that the method in which Twinkle modules are loaded changed, so anyone who maintains an up-to-date Twinkle gadget will have to update the gadget definition as well. Twinkle-related changes and deprecations include:
- Decentralise module initialisations (#946, by SD0001)
- morebits: Remove tipsy dependency, use jQuery UI for tooltips (#971)
- Remove useragent 2.0 specification (#970)
- Merge individual chunk prefs into one: batchChunks (#978)
- Note dependencies on mediawiki.Title (morebits) and mediawiki.api (Twinkle) (#983)
- Use
Twinkle.hatnoteRegex
to store hatnote templates (#1022)
For the more technical folks, there were a number of behind the scenes improvements that might be interesting:
- Add
Morebits.quickForm.getInputData
for easy access to form data (#908, by SD0001) - form getters: don't return null (#908, by SD0001)
- quickForm: add
shiftClickSupport
option for checkboxes (#1041, by SD0001) - Allow chaining of
Morebits.wikitext.page
methods (#1022) - Add insertAfterTemplates to wikitext.page (#1022)
- Add ability to not follow cross-namespace redirects (#915, by SD0001)
- fix ability to query in JSON (#1007)
- api: auto-retry on badtoken errors. (#1038, by SD0001)
- api: use GET for all action=query requests (#1038, by SD0001)
- api: use formatversion=2 by default while making API calls in JSON (#1038, by SD0001)
- Don't allow null append or prepend text (#1032)
~ Amory (u • t • c) 15:43, 19 July 2020 (UTC)
Merging feature should be implemented on Twinkle
I installed Twinkle originally to revert vandalism. However, I found that XfD nominations become very simple in Twinkle. Unfortunately, I cannot use Twinkle to request to merge articles. Therefore, I request to semi-autonomise the requested merge. Thank you. --Soumya-8974 talk contribs subpages 17:01, 2 August 2020 (UTC)
- Soumya-8974, you can. It's in the tag section. I missed it for ages as well. --Trialpears (talk) 17:02, 2 August 2020 (UTC)
- Thank you --Soumya-8974 talk contribs subpages 17:03, 2 August 2020 (UTC)
RPP placed in wrong section
Existing semi-protection on Herbert Hoover expired today at 00:40 UTC. At 01:11 UTC, I saw it come up in recent changes and navigated to it. At 01:13 UTC, I decided to request that semi-protection be restored, but Twinkle thought the page was already protected for some reason, and so put the request under "Current requests for reduction in protection level" instead of "Current requests for increase in protection level" (Special:Diff/971913636). Jackmcbarn (talk) 01:19, 9 August 2020 (UTC)
- Jackmcbarn, The article appears to be pending changes-protected. Adam9007 (talk) 01:23, 9 August 2020 (UTC)
- @Adam9007: It is, but pending-changes is weaker than semi-protection, so it still shouldn't have counted as a reduction to change to semi-protection. Jackmcbarn (talk) 01:25, 9 August 2020 (UTC)
- The page was also move-protected at the sysop level. Still, though, that's not great behavior. ~ Amory (u • t • c) 09:58, 9 August 2020 (UTC)
- @Adam9007: It is, but pending-changes is weaker than semi-protection, so it still shouldn't have counted as a reduction to change to semi-protection. Jackmcbarn (talk) 01:25, 9 August 2020 (UTC)
Error with XfD
Hi everyone,
I AfD'ed Skotos this afternoon, but I got an error that a token could't be retrieved and Twinkle failed to create a page for the discussion. See the diff; I created Wikipedia:Articles for deletion/Skotos myself manually. soetermans. ↑↑↓↓←→←→ B A TALK 12:52, 10 August 2020 (UTC)
- As noted at WT:WPVG, it was probably a blip in connectivity between you and the server. Hard to say for sure without the full console error report, but that's the most likely reason. ~ Amory (u • t • c) 10:09, 11 August 2020 (UTC)
Adding a new report
Hi, I want to know how to add a new report to the old sockpuppet investigation? Thank you TheBirdsShedTears (talk) 03:14, 12 August 2020 (UTC)
- TheBirdsShedTears, wouldn't you just go ARV > Sockpuppet > then in Sockpuppeteer enter the name of the master sock subject to the old SPI - or if an investigation is already active, you should edit the investigation thread manually to add new socks. Ed talk! 09:59, 12 August 2020 (UTC)
- Thank you for this help. TheBirdsShedTears (talk) 10:54, 12 August 2020 (UTC)
AN3 not working
Trying to report this user's reverts on А́ to AN3 does not work for me. Clicking "Load" turns up nothing. I wonder if it has to do with the fact А́ is currently a redirect. Nardog (talk) 05:18, 2 August 2020 (UTC)
- Yes, indeed! That's been the case since the feature was added in 2013 but I can't say I'm entirely sure why it's a good idea. ~ Amory (u • t • c) 10:08, 2 August 2020 (UTC)
- @Amorymeltzer: So what's stopping you from removing this function? Nardog (talk) 14:26, 11 August 2020 (UTC)
- Haven't had the time to go through and test where and when it might be desired. There's been no comment from anyone else so (absence of evidence ≠ evidence of absence aside) perhaps it's not a big concern. ~ Amory (u • t • c) 11:41, 12 August 2020 (UTC)
- @Amorymeltzer: So what's stopping you from removing this function? Nardog (talk) 14:26, 11 August 2020 (UTC)
Not notifying creator of a BLPprod article
When I blpprodded Dolly-Rose Campbell I expected Twinkle to notify its creator, but it didn't? A bug, a temporary glitch, or have I accidentally unset a setting? PamD 06:46, 5 August 2020 (UTC)
- @PamD: Did you navigate away from the page between when the tag got placed and when the notification got sent? Jackmcbarn (talk) 21:09, 5 August 2020 (UTC)
- @Jackmcbarn: I prodded the article, did a couple more edits, edited another article and then for some reason checked the creating editor's page, found there wasn't a message, and added it manually. It's likely, from the timing, that I was editing on phone when I prodded and then on laptop later. PamD 22:04, 5 August 2020 (UTC)
- I've had the same problem twice this week. power~enwiki (π, ν) 04:08, 6 August 2020 (UTC)
This was fixed by Amorymeltzer a week back. SD0001 (talk) 11:24, 19 August 2020 (UTC)
Help for blocking
Twinkle isn't showing up
I have Twinkle enabled, but it's not showing up for some reason. I think it started today or last night. Mvcg66b3r (talk) 19:42, 28 August 2020 (UTC)
- Yes, I had that a number of times yesterday. If I shutdown the browser and restarted it the problem seemed to have gone away, but then came back later. I had assumed that the problem was at my end as I didn't see any other reports, but it sounds as if it is more widespread. As well as losing Twinkle I had also lost RedWarn (which I use in parallel with Twinkle). Presumably there is some common path which affects both? --David Biddulph (talk) 19:47, 28 August 2020 (UTC)
- Now they just came back up. What gives? There are also two fields on the left panel that say "Scripts" in bold. Could that be that same thing? Mvcg66b3r (talk) 19:52, 28 August 2020 (UTC)
- This might be a Wikipedia:THURSDAY issue, deployment of mw:MediaWiki 1.36/wmf.6 was completed then, so I'll do some digging. Can't say I experienced this issue myself, however. Ed talk! 19:58, 28 August 2020 (UTC)
- Now they just came back up. What gives? There are also two fields on the left panel that say "Scripts" in bold. Could that be that same thing? Mvcg66b3r (talk) 19:52, 28 August 2020 (UTC)
- Twinkle is coming up for me, but has stopped working. Emir of Wikipedia (talk) 14:52, 29 August 2020 (UTC)
- @Emir of Wikipedia: Do the interface dialogs show up? Are there any errors in the browser console? SD0001 (talk) 17:44, 29 August 2020 (UTC)
- Never mind it is working now. The interface dialogues were showing up previously, but after clicking submit query nothing was happening. Emir of Wikipedia (talk) 17:54, 29 August 2020 (UTC)
- @Emir of Wikipedia: Do the interface dialogs show up? Are there any errors in the browser console? SD0001 (talk) 17:44, 29 August 2020 (UTC)
Bug: no space between template message and personal message
Hello. I noticed that a warning message I placed with Twinkle inserted my personal comment directly after the template message, without a space placed in between: [5]. Do with it what you will. — Tartan357 (Talk) 09:11, 28 August 2020 (UTC)
- That's because of the template, {{uw-ew}}. Many (most?) warning templates have an additional parameter for such a personal comment, and it automatically handles the extra space. {{uw-ew}} has the parameter, but before this edit it added a {{break}}; that edit meant there is now no whitespace. I just added a space, so I think it should work? ~ Amory (u • t • c) 10:50, 31 August 2020 (UTC)
What went wrong with this attempt to make a merge request?
[6]. It didn't put a tag on the other article or create a talk page section. Doug Weller talk 17:26, 3 September 2020 (UTC)
- In the notice it did place, it shows extra link brackets. I assume you added them where they weren't needed when you typed in the forms. Just a guess on my part, as I know absolutely nothing about the nuts-and-bolts of Twinkle. BilCat (talk) 20:29, 3 September 2020 (UTC)
- That's correct.
[[Virginia Citizens Defense League]]
parses as an invalid title to the API. We shoul really be modernising these page input menus, but OOUI isn't compatible with rest of the UI so it's more tricky than simply embedding an mw.widgets.titleInputWidget in there. – SD0001 (talk) 06:37, 4 September 2020 (UTC)- Also invalid to
mw.Title
(but modified to((Virginia Citizens Defense League))
bynewFromUserInput
). ~ Amory (u • t • c) 10:25, 5 September 2020 (UTC)
- Also invalid to
- That's correct.
Following redirects for block notices
I rather embarrassingly left Ymblanter a block notice today. The LTA I intended to block had redirected their talk page to Ymblanter's, and while the correct account was blocked, the block notice was sent to the incorrect recipient. Rather than admit that I should have checked the talk page before blocking, I'm choosing to blame Twinkle instead – is there any reason that block notices need to follow redirects? Could this be changed? – bradv🍁 22:54, 30 August 2020 (UTC)
This has already been fixed. Will get deployed in the next on-wiki update.— SD0001 (talk) 04:54, 31 August 2020 (UTC)- This was a UT->UT redirect, so the (already deployed) cross-namespace check didn't prevent it. ~ Amory (u • t • c) 10:45, 31 August 2020 (UTC)
- Bot accounts, alt-accounts, etc. often redirect their user talk pages to the main account. If Amory was compromised and you blocked it, the notice would get passed on to me, which is good (or at least better than overwriting the redirect). The block will still be applied to the original user account (e.g. Amory) so following the redirect arguably makes less sense than for a warning or CSD note, for example, but that's the theory behind it. In short: it's mostly for well-behaving folks, but miscreants can abuse it; in general sysops should probably peek at the talk page before blocking. ~ Amory (u • t • c) 10:45, 31 August 2020 (UTC)
- Ideally, there should be a prompt before twinkle follows a redirect for block and warn modules. Not worth it for the deletion modules I guess. – SD0001 (talk) 10:59, 31 August 2020 (UTC)
- That's a reasonable idea; there are other tools that give a warning if the page to be affected is a redirect (sort of a "which page are you referring to?" check). Don't know how problematic it would be to add, though. Primefac (talk) 15:12, 31 August 2020 (UTC)
- Indeed. I suggested it in April and I guess that'd be best of both worlds? ~ Amory (u • t • c) 12:22, 2 September 2020 (UTC)
- That's a reasonable idea; there are other tools that give a warning if the page to be affected is a redirect (sort of a "which page are you referring to?" check). Don't know how problematic it would be to add, though. Primefac (talk) 15:12, 31 August 2020 (UTC)
- Amorymeltzer, I can't imagine a situation where I would block an account and want another account to receive a notice saying "
Your account has been blocked indefinitely
". In any of those scenarios, the account that's blocked should receive the actual notice, and the bot- or alt-owner provided with some sort of manual heads-up. – bradv🍁 14:58, 31 August 2020 (UTC)- Word. There's (currently, though I'm working on it) no easy way to do all that at once, but mainly because there's no unified way to indicate "hey this account really does belong to that other account" (at least not reliably). ~ Amory (u • t • c) 12:22, 2 September 2020 (UTC)
- Ideally, there should be a prompt before twinkle follows a redirect for block and warn modules. Not worth it for the deletion modules I guess. – SD0001 (talk) 10:59, 31 August 2020 (UTC)
- @Amorymeltzer:, please expedite reviewing and deploying https://github.com/azatoth/twinkle/pull/1118, which fixes this long-term security/harassment bug in Twinkle. ST47 (talk) 11:56, 2 September 2020 (UTC)
- In the interim, sysops might consider adding the following code to common.js if they would rather not facilitate this LTA's harassment campaign. ST47 (talk) 12:00, 2 September 2020 (UTC)
mw.loader.using( ['ext.gadget.Twinkle'], function () {
Twinkle.block.callback.issue_template = function twinkleblockCallbackIssueTemplate(formData) {
var userTalkPage = 'User_talk:' + mw.config.get('wgRelevantUserName');
var params = $.extend(formData, {
messageData: Twinkle.block.blockPresetsInfo[formData.template],
reason: Twinkle.block.field_template_options.block_reason,
disabletalk: Twinkle.block.field_template_options.notalk,
noemail: Twinkle.block.field_template_options.noemail_template,
nocreate: Twinkle.block.field_template_options.nocreate_template
});
Morebits.wiki.actionCompleted.redirect = userTalkPage;
Morebits.wiki.actionCompleted.notice = 'Actions complete, loading user talk page in a few seconds';
var wikipedia_page = new Morebits.wiki.page(userTalkPage, 'User talk page modification');
wikipedia_page.setCallbackParameters(params);
wikipedia_page.setFollowRedirect(false);
wikipedia_page.load(Twinkle.block.callback.main);
};
});
- As I said there, I've come around to this, especially as it seems LTAs are abusing it and sysops aren't checking talk pages. What's the security risk? ~ Amory (u • t • c) 12:22, 2 September 2020 (UTC)
- The security risk is that Eostrix, Girth Summit, and others have effectively had their sessions hijacked to leave messages on an attacker-controlled page. If an attacker can abuse a tool in order to continue a harassment campaign even after the attacker is blocked and banned, that is absolutely a security defect in the tool. I've created filter 1082 to prevent the creation of this class of redirects on this wiki, but I have some concerns that it may be possible to bypass the filter, and of course Twinkle is used on many wikis other than this one. ST47 (talk) 13:03, 2 September 2020 (UTC)
- It's not really important, but I would really disagree with
sessions hijacked
. That implies someone else is taking control of the account, which is not true. ~ Amory (u • t • c) 10:19, 5 September 2020 (UTC)
- It's not really important, but I would really disagree with
- Adding emphasis here, when I am CSD tagging (which I can do quite fast, even a few a minute when the pages are copies/clones by the same user, e.g. [7]) I generally don't think twice about the talk page target - up to now I assumed Twinkle did it correctly and that the creator would be notified (and other users would have a warning/speedy trail on the talk page) - there usually is little need for me to look at the user's talk page prior to CSDing (as it isn't user dependent, it is created page dependent). However with this redirect exploit - the end result is that I am bombing the harassment target at a high rate with templates/notifications that aren't intended for them. With really fast vandals - it might be me and a few other users at NPP/RCP bombing the harassment target. So yes - I've turned off the notify creator for ones I know who are redirecting their talk - but I'd prefer Twinkle not deliver these through redirects.--Eostrix (🦉 hoot hoot🦉) 13:26, 2 September 2020 (UTC)
- The security risk is that Eostrix, Girth Summit, and others have effectively had their sessions hijacked to leave messages on an attacker-controlled page. If an attacker can abuse a tool in order to continue a harassment campaign even after the attacker is blocked and banned, that is absolutely a security defect in the tool. I've created filter 1082 to prevent the creation of this class of redirects on this wiki, but I have some concerns that it may be possible to bypass the filter, and of course Twinkle is used on many wikis other than this one. ST47 (talk) 13:03, 2 September 2020 (UTC)
- As I said there, I've come around to this, especially as it seems LTAs are abusing it and sysops aren't checking talk pages. What's the security risk? ~ Amory (u • t • c) 12:22, 2 September 2020 (UTC)
- It would be nice if Twinkle gave a pop-up for any talk page post via redirect, or maybe not follow redirects created by non-AC users. I just templated ST47 when CSDing attack pages by User:ST47 (9-2). In many twinkle messages it is very wrong to WP:AGF in regards to the recipient and redirects on his page. For AfD/PROD yes - but nearly all other messages are not a good faith situation.--Eostrix (🦉 hoot hoot🦉) 12:25, 2 September 2020 (UTC)
ST47's fix has now been deployed when blocking users. ~ Amory (u • t • c) 17:42, 5 September 2020 (UTC)
Noticeboard notification problem
I just sent out a half-dozen or so noticeboard notifications for a thread at WP:AN. I selected AN from the drop-down menu and the edit summaries indicate that the notification is for AN, yet the actual notification is linking to ANI. See [8] for example. LEPRICAVARK (talk) 18:13, 15 August 2020 (UTC)
- Lepricavark, How do you post that notice anyway? It tried to test it, but couldn't find any option for it. Adam9007 (talk) 18:19, 15 August 2020 (UTC)
- From the user talk page, select 'TB' from the drop-down menu. Then click the 'Noticeboard notification' radio button and select AN from the top of the drop-down menu. LEPRICAVARK (talk) 18:20, 15 August 2020 (UTC)
- Lepricavark, Thanks. I didn't think to check TB :$. Adam9007 (talk) 18:23, 15 August 2020 (UTC)
- Yep. I can confirm that AN links to ANI. Adam9007 (talk) 18:24, 15 August 2020 (UTC)
- From the user talk page, select 'TB' from the drop-down menu. Then click the 'Noticeboard notification' radio button and select AN from the top of the drop-down menu. LEPRICAVARK (talk) 18:20, 15 August 2020 (UTC)
- Fixed [9] though a better fix would be to have Twinkle post Template:AN-notice instead of Template: ANI-notice with a noticeboard parameter. SD0001 (talk) 12:04, 19 August 2020 (UTC)
- I'd say rather the issue is that {{AN-notice}} is insufficient, mainly since it doesn't allow for header customization. Can I Log In recently created {{Discussion notice}} and then immediately restructured {{ANI-notice}} to use it. Despite being new, is there a good reason that {{AN-notice}} shouldn't be similarly restructured? The default header is unsupported atm. In content, the two notices are barely distinguishable, and appear to exist separately mainly for convenience; it'd make sense for them to be based upon a base template. ~ Amory (u • t • c) 11:07, 10 September 2020 (UTC)
- Alternatively (or, rather, orthogonally), {{ANI-notice}} and {{AN-notice}} are the only two templates for which we have the
adminNoticeHeading
preference. We could just be rid of that, and make life simpler overall. That's probably my preference, although it shouldn't mean not doing the above. It does seem like {{ANI-notice}}} is the odd-one-out by not providing a section header. ~ Amory (u • t • c) 11:13, 10 September 2020 (UTC)
- Alternatively (or, rather, orthogonally), {{ANI-notice}} and {{AN-notice}} are the only two templates for which we have the
- I'd say rather the issue is that {{AN-notice}} is insufficient, mainly since it doesn't allow for header customization. Can I Log In recently created {{Discussion notice}} and then immediately restructured {{ANI-notice}} to use it. Despite being new, is there a good reason that {{AN-notice}} shouldn't be similarly restructured? The default header is unsupported atm. In content, the two notices are barely distinguishable, and appear to exist separately mainly for convenience; it'd make sense for them to be based upon a base template. ~ Amory (u • t • c) 11:07, 10 September 2020 (UTC)
A separate preference to toggle adding redirects to watchlist after tagging
Hello, it would be nice to have a sub-preference of "Add page to watchlist when tagging" in the "Tag" section of the preferences to toggle the behaviour specifically for redirects. 𝟙𝟤𝟯𝟺𝐪𝑤𝒆𝓇𝟷𝟮𝟥𝟜𝓺𝔴𝕖𝖗𝟰 (𝗍𝗮𝘭𝙠) 21:44, 3 September 2020 (UTC)
- @1234qwer1234qwer4: Just to clarify, you're asking for different preferences for maintenance, redirect, and file taggings, yeah? ~ Amory (u • t • c) 11:54, 10 September 2020 (UTC)
- @Amorymeltzer: Thanks, I wasn't aware of file tagging as I'm not active in the file namespace outside of Commons. Yes, that is what I'd suggest. 𝟙𝟤𝟯𝟺𝐪𝑤𝒆𝓇𝟷𝟮𝟥𝟜𝓺𝔴𝕖𝖗𝟰 (𝗍𝗮𝘭𝙠) 12:00, 10 September 2020 (UTC)
CSD deletion - alternate reasons?
I've done a couple of deletions now where there is "extra" info, most recently U.S. Route 10 Alternate (Washington–Montana) (see log if it's been recreated), but when I put in that extra info it's not adding it to the deletion summary (for example, the db-move I used above should have included "AFC submission ready for acceptance"). Is this a recent change or have I just never noticed that Twinkle doesn't do this? Primefac (talk) 16:44, 8 September 2020 (UTC)
- @Primefac: It been that way for ages (ever?). The proximate reason is that Twinkle uses the
summary
parameter from the rendered template, and {{db-move}} doesn't handle extra parameters well, just a custom summary. I've been meaning to go through all the CSD templates and audit their deletion reasons for a while; last time I did some work on them there were some inconsistencies. Twinkle could try to customize adding parameters, but if the templates themselves would make use of the parameters provided, it'd be more beneficial for everyone. At the very least, though, Twinkle shouldn't require you to enter parameters that will be dumped and ignored. I would guess G6s are probably the worst offenders, are there others that come to mind? As a stopgap, you can select certain criteria for Twinkle to prompt you to edit the default deletion log entry before deleting, that's in your Twinkle preferences. ~ Amory (u • t • c) 17:15, 8 September 2020 (UTC)- Well, I guess that shows how much I pay attention to pages I delete... G6 is the only one I would be using it regularly for. I remember there was a non-G6 deletion I did at some point last week that had the same issue, but since there's no extra summary I can't find it! In the meantime, if there's something that needs further explanation I'll just use the regular delete menu. Primefac (talk) 17:28, 8 September 2020 (UTC)
- @Primefac: Check out this diff to db-move (sandbox), what do you think? That would allow all sysops (including Twinkle) to make use of the parameters in the default deletion summary. I can start a section on Template talk:Db-meta. ~ Amory (u • t • c) 20:38, 12 September 2020 (UTC)
- Seems like a good idea. Primefac (talk) 17:43, 13 September 2020 (UTC)
- @Primefac: Check out this diff to db-move (sandbox), what do you think? That would allow all sysops (including Twinkle) to make use of the parameters in the default deletion summary. I can start a section on Template talk:Db-meta. ~ Amory (u • t • c) 20:38, 12 September 2020 (UTC)
- Well, I guess that shows how much I pay attention to pages I delete... G6 is the only one I would be using it regularly for. I remember there was a non-G6 deletion I did at some point last week that had the same issue, but since there's no extra summary I can't find it! In the meantime, if there's something that needs further explanation I'll just use the regular delete menu. Primefac (talk) 17:28, 8 September 2020 (UTC)
September 2020 Twinkle updates, features, and behaviors (2020-09-05) @10b4f79c
Twinkle now uses change tags for all its actions! You should start seeing it immediately, and be able to filter edits and actions accordingly. Beyond that, there are a number of other improvements and bug fixes; a brief summary of some of them are below. Changes not otherwise attributed were made by User:Amorymeltzer.
- Everywhere:
- xfd:
- xfd/prod:
- Show {{Find sources}} links in AfD and PROD windows (#1052, by SD0001)
- Handle lists in userspace logging (#1110, by SD0001)
- prod:
- block:
- Prevent infinite blocks of IP addresses (#1097)
- add uw-botuhblock (#1089) (#1095, by Mdaniels5757)
- Don't confirm no restrictions if email harassment is selected (#1075)
- image: Fix bug parsing namespace in replacement (#1115)
- revert and rollback:
- speedy: Follow page watch preference when deleting (#1116)
- tag:
- Add {{Image hoax}} (#996)
- Fix checking for wrong extension in "Should be" templates (#1114)
- protect: Ensure move protection is valud (#1071)
- preferences: Remove obsolete torev option from openTalkPage (#965)
This section should serve as a catching ground should anything not work properly or if any new bugs crop up, as well as for any feedback or suggestions. There were a lot of changes behind the scenes, so feel free to ping me. As always, input is welcome at the GitHub repo as well. Finally, if you're interested in helping out with Twinkle development, there's a guideline to help new contributors get set up — check it out! ~ Amory (u • t • c) 17:31, 5 September 2020 (UTC)
Technical changes
The Morebits library has added RegExp.escape
for a while; this has been deprecated in favor of Morebits.string.escapeRegExp
; see #1077 for more info. It also added Morebits.string.isInfinity
to check whether mediawiki will parse a string as infinite (#1057).
~ Amory (u • t • c) 17:31, 5 September 2020 (UTC)
- @SD0001: Hey there, I'm not sure if it's a result of the font size changes you made, but some changes recently now make the Twinkle font smaller in my Windows 10 Chrome browser. I thought I was nuts at first and somehow zoomed out of the page, but my normal Wikipedia browsing experience is unchanged, other than how Twinkle displays. Thoughts? Thanks, Cyphoidbomb (talk) 18:23, 6 September 2020 (UTC)
- @Cyphoidbomb: Which skin do you use (vector/monobook/...)? I don't see any issues in Chrome on Windows 10 at my end. If possible, can you check what is the rendered font size using the browser's inspect element tool? Temporarily, you can try enabling the "Use larger text in Twinkle dialogs" option in your WP:TWPREFS and see if that helps. – SD0001 (talk) 18:56, 6 September 2020 (UTC)
- @SD0001:} I use Vector. I know how to access the inspect element tool, but I don't know what string I'm supposed to be looking for. I see a lot of "font-size" stuff after right-clicking an open Twinkle window and selecting Inspect element, then searching for "font". In case it's helpful, my browser is set to Large fonts and 100% page zoom. Also, when I used to open the Protect Page window, the pulldowns for "Edit protection: Autoconfirmed Expires: 2 days" (for example) used to be on two lines. Now they line up, which is aesthetically pleasing, but the font size is a bit smaller now. I did tick the "Use large text" option per your suggestion, but it didn't make a difference. Let me know what other info I can give you. Thanks, Cyphoidbomb (talk) 18:08, 7 September 2020 (UTC)
- @Cyphoidbomb: With any Twinkle window opened, press Ctrl+Shift+C. Now hover (don't click) over any text inside the Twinkle window. A popup should show up like this which shows the font details. – SD0001 (talk) 08:09, 8 September 2020 (UTC)
- @SD0001: A-ha! Thank you. I see 12px sans-serif in the Twinkle box. With my Chrome font set to Large, the article text (and on talk pages, etc) is 16.25px. If I change my Chrome font size to Medium, article text goes down to 13px but the Twinkle font stays at 12px. If I change the Chrome font size to Extra Large. Article text goes up to 19.5px, Twinkle stays at 12px. Regards, Cyphoidbomb (talk) 16:45, 8 September 2020 (UTC)
- Noted. Thanks for the info. It means Twinkle needs to mention the font size using relative percentages rather than an absolute "12px". – SD0001 (talk) 12:53, 9 September 2020 (UTC)
- @SD0001: Thanks for taking this into consideration! You'd make my eyes grateful. Also, the window(s) might need to scale up to accommodate different font sizes, which I don't think I was experiencing before (hence the fields not always lining up horizontally on my display). Thanks, Cyphoidbomb (talk) 04:22, 10 September 2020 (UTC)
- @Cyphoidbomb: Yesterday I made some changes to Twinkle on the testwiki. Can you enable Twinkle over there and confirm if everything looks all right? – SD0001 (talk) 17:44, 12 September 2020 (UTC)
- @SD0001: Hey there, thanks for working on it. It looks much better. The only difference I note is that the article text size is 16.1px where the Twinkle text is about 15. I'm not sure if that difference matters so much. I don't have my admin tools at the test site, so I can't do an exact test drive, but otherwise it looks pretty good! Thanks again, Cyphoidbomb (talk) 18:14, 12 September 2020 (UTC)
- @Cyphoidbomb: Yesterday I made some changes to Twinkle on the testwiki. Can you enable Twinkle over there and confirm if everything looks all right? – SD0001 (talk) 17:44, 12 September 2020 (UTC)
- @SD0001: Thanks for taking this into consideration! You'd make my eyes grateful. Also, the window(s) might need to scale up to accommodate different font sizes, which I don't think I was experiencing before (hence the fields not always lining up horizontally on my display). Thanks, Cyphoidbomb (talk) 04:22, 10 September 2020 (UTC)
- Noted. Thanks for the info. It means Twinkle needs to mention the font size using relative percentages rather than an absolute "12px". – SD0001 (talk) 12:53, 9 September 2020 (UTC)
- @SD0001: A-ha! Thank you. I see 12px sans-serif in the Twinkle box. With my Chrome font set to Large, the article text (and on talk pages, etc) is 16.25px. If I change my Chrome font size to Medium, article text goes down to 13px but the Twinkle font stays at 12px. If I change the Chrome font size to Extra Large. Article text goes up to 19.5px, Twinkle stays at 12px. Regards, Cyphoidbomb (talk) 16:45, 8 September 2020 (UTC)
- @Cyphoidbomb: With any Twinkle window opened, press Ctrl+Shift+C. Now hover (don't click) over any text inside the Twinkle window. A popup should show up like this which shows the font details. – SD0001 (talk) 08:09, 8 September 2020 (UTC)
- @SD0001:} I use Vector. I know how to access the inspect element tool, but I don't know what string I'm supposed to be looking for. I see a lot of "font-size" stuff after right-clicking an open Twinkle window and selecting Inspect element, then searching for "font". In case it's helpful, my browser is set to Large fonts and 100% page zoom. Also, when I used to open the Protect Page window, the pulldowns for "Edit protection: Autoconfirmed Expires: 2 days" (for example) used to be on two lines. Now they line up, which is aesthetically pleasing, but the font size is a bit smaller now. I did tick the "Use large text" option per your suggestion, but it didn't make a difference. Let me know what other info I can give you. Thanks, Cyphoidbomb (talk) 18:08, 7 September 2020 (UTC)
- @Cyphoidbomb: Which skin do you use (vector/monobook/...)? I don't see any issues in Chrome on Windows 10 at my end. If possible, can you check what is the rendered font size using the browser's inspect element tool? Temporarily, you can try enabling the "Use larger text in Twinkle dialogs" option in your WP:TWPREFS and see if that helps. – SD0001 (talk) 18:56, 6 September 2020 (UTC)
- 1128 – SD0001 (talk) 06:46, 15 September 2020 (UTC)
Unable to add Template:Bad trace
Hello!
When I was trying to add {{Bad trace}} to File:Amber Sound FM logo.svg I got this error message: This appears to be a svg file, please use {{Bad SVG}} instead. which is very weird, since it is SVGs that can be autotraced.Jonteemil (talk) 12:15, 15 September 2020 (UTC)
- Yup! Bug from when I added checks for extensions to certain tags (like {{Bad SVG}}, etc.) because I'm dumb. This should be fixed now. ~ Amory (u • t • c) 10:36, 16 September 2020 (UTC)
merge helper
There are several articles I'm trying to propose a merger into one article. Despite removing "tag the target" check box, it keeps tagging up the target and causing me frustrations as you can see in the edit history at Atlassian. Why is this happening? Graywalls (talk) 00:55, 10 September 2020 (UTC)
- Sorry for just seeing this today, Graywalls, but that's a bona fide bug! I fixed it at https://github.com/azatoth/twinkle/pull/1125 and pushed it up live, should work from here on out! ~ Amory (u • t • c) 15:08, 12 September 2020 (UTC)
- @Amorymeltzer:, so do I have to do anything on my end to update it like reinstalling it in my user profile? Graywalls (talk) 04:40, 16 September 2020 (UTC)
- Nope, you should be all set! There's a small chance you'd need to refresh your cache, but you should be good to go. ~ Amory (u • t • c) 10:37, 16 September 2020 (UTC)
- @Amorymeltzer:, so do I have to do anything on my end to update it like reinstalling it in my user profile? Graywalls (talk) 04:40, 16 September 2020 (UTC)
Uw-afd series RM
These templates are used by Twinkle, so you may want to see the discussion at Wikipedia_talk:Template_index/User_talk_namespace#Requested_move_16_September_2020. Adam9007 (talk) 19:55, 16 September 2020 (UTC)
Add {{subst:Welcome-anon-unsourced}}
Self-explanatory. The template is not on Twinkle for some reason. Mvcg66b3r (talk) 04:33, 19 September 2020 (UTC)
"R avoided double redirect" should have a parameter for the redirect avoided. 𝟙𝟤𝟯𝟺𝐪𝑤𝒆𝓇𝟷𝟮𝟥𝟜𝓺𝔴𝕖𝖗𝟰 (𝗍𝗮𝘭𝙠) 08:26, 23 September 2020 (UTC)
"Historic name" vs. "former name" for redirects
It's not at all clear in the Twinkle redirect tagging box that "historic name" refers to a former name of the subject, whereas "former name" refers to a former name of the subject's article (at least I think). Could the descriptions please be improved? {{u|Sdkb}} talk 22:29, 21 September 2020 (UTC)
- From the documentation of {{R from historic name}} and {{R from former name}}, both appear to refer to former names of the subject, the difference being whether the name has historical significance, like Ceylon, or not, like Rubber (band). However, there are plenty of cases where one could argue for either, and a few which seem blatantly wrong. For former names of the article, we have {{R from move}}. Certes (talk) 22:41, 21 September 2020 (UTC)
- @Certes: Hmm, thanks for the clarification. I think the twinkle descriptions could still be improved, since if they gave me the wrong impression they probably are others as well. I also wonder if these really need to be separate; have they been considered for merging? {{u|Sdkb}} talk 08:33, 23 September 2020 (UTC)
- I'm rarely sure which to use, and my choices may be based on opinion rather than fact, so I'm not sure we gain much by distinguishing them. Certes (talk) 10:04, 23 September 2020 (UTC)
- Certes, I've nominated for merging at Wikipedia:Templates_for_discussion/Log/2020_September_23#Template:R_from_historic_name. {{u|Sdkb}} talk 19:31, 23 September 2020 (UTC)
- I'm rarely sure which to use, and my choices may be based on opinion rather than fact, so I'm not sure we gain much by distinguishing them. Certes (talk) 10:04, 23 September 2020 (UTC)
- @Certes: Hmm, thanks for the clarification. I think the twinkle descriptions could still be improved, since if they gave me the wrong impression they probably are others as well. I also wonder if these really need to be separate; have they been considered for merging? {{u|Sdkb}} talk 08:33, 23 September 2020 (UTC)
Query
Hi, this is a small query, today when I used twinkle after a long time to revert an edit I saw from my controls it dosent have (tw) in it after the summary, is it just my problem or has twinkle been updated?Antila ✉ 08:19, 24 September 2020 (UTC)
- @Antila: See #September 2020 Twinkle updates, features, and behaviors (2020-09-05) @10b4f79c; it uses an edit tag now. 𝟙𝟤𝟯𝟺𝐪𝑤𝒆𝓇𝟷𝟮𝟥𝟜𝓺𝔴𝕖𝖗𝟰 (𝗍𝗮𝘭𝙠) 08:26, 24 September 2020 (UTC)
Late notifcation again
{{Uw-3rr}} is being discussed for merger with {{Uw-ew}} again, at Wikipedia:Templates_for_discussion/Log/2020_September_26#Template:Uw-3rr. Techie3 (talk) 00:46, 26 September 2020 (UTC)
Error Deleting page: Failed to delete the page: The tag "twinkle" is not allowed to be manually applied.
Hello, I am updating Twinkle for viwiki. I don't know what this error is? Alphama (talk) 03:45, 23 September 2020 (UTC)
- @Alphama: Create the tag named "twinkle" first, using Special:Tags (you'll need to be an admin). Twinkle on enwiki recently switched from edit summary ads to using tags. – SD0001 (talk) 04:40, 23 September 2020 (UTC)
- @SD0001: Ok, thank. I am admin of viwiki. Alphama (talk) 15:49, 26 September 2020 (UTC)
XFD
The dialog stays put after it finishes the job instead of closing itself and preferably reloading the page or opening the deletion discussion entry. It is confusing as that's what also happens if there is a disconnect while it is in the middle of the job. Isn't just me, is it? Thanks! Usedtobecool ☎️ 08:54, 29 September 2020 (UTC)
- @Usedtobecool: Which namespace (AFD/RFD/FFD/...)? – SD0001 (talk) 08:59, 29 September 2020 (UTC)
- SD0001, AFD. I do AFD almost exclusively, I don't know why I wrote X. Usedtobecool ☎️ 09:03, 29 September 2020 (UTC)
Bug report -> Inaccessible drop-down menu in Visual Editor for New Vector users
The search box has been moved to the right side of the logo in New Vector skin, so the TW tab is now the rightmost item among the tabs above the page. The new change has also revealed an important issue, which affects users when the Visual Editor is used.
In order to replicate the issue, enable the VE if you haven't, go to any article of your choice, and click the Edit button so that you see ?veaction=edit
in the address bar. Then you will notice that the [Publish changes...] button disallows access to the contents of the TW drop-down. Other items that may be there such as the [Page] & [User] tabs introduced by m:MoreMenu, or the default [More] button are fine.
Let me also ping Amorymeltzer, because an urgent fix might be needed here.
Vito Genovese 14:16, 1 October 2020 (UTC)
- For me, even the "More" menu behaves likewise, which means it's worth reporting to phab. Putting a z-index of 3 on on the ul elements fixes the issue at my end. – SD0001 (talk) 15:08, 1 October 2020 (UTC)
- Oh yeah, I was also wondering about that, because More behaves okay at enwiki, but not at trwiki for me (with an up-to-date version of Twinkle on its right).
- Vito Genovese 15:18, 1 October 2020 (UTC)
- Yeah, I get the overlap with the "More" menu, so this looks like a VE bug (or, at least, a bug with not considering VE). Phabricator would indeed be the right place to report it. ~ Amory (u • t • c) 15:41, 1 October 2020 (UTC)
XfD feature issue
So, I tried to nominate a template for deletion, but it choked and halted because it was protected beyond my privilege. Nonetheless, it went ahead and added it to the deletion log and notified the creator even though the actual nomination didn't go through. I had to revert all those; request an admin to unprotect the target, then repeat the whole thing all over. Could an improvement be made, so Twinkle doesn't proceed with listing things for deletion and notifying the creator until it succeeds the actual nomination step? Graywalls (talk) 10:49, 3 October 2020 (UTC)
Bug report - Laos in Africa?
Laos is a country in Asia. However, when using the DelSort feature for AFD nominations in Twinkle, Laos is sorted under "Africa". power~enwiki (π, ν) 18:31, 3 October 2020 (UTC)
- Indeed! Looks like WP:DS/C has had some changes lately. Just pushed an update fixing this, as well as updating a bunch of other delsort items. ~ Amory (u • t • c) 20:08, 3 October 2020 (UTC)
Repeated error
Twice in the last 15 minutes or so I've nominated two articles at AfD through Twinkle (Wikipedia:Articles for deletion/List of Baltimore Police Department officers killed in the line of duty and Wikipedia:Articles for deletion/List of Los Angeles Police Department officers killed in the line of duty) and Twinkle has failed to create the AfD page or add the discussion to DELSORT pages (while successfully tagging the article, adding the AfD to the daily log, and notifying the creator). It showed me an error message in red, though I can't remember what it said, and, I believe, said it was re-trying, though apparently to no avail. In the same time I've successfully nominated two other articles with no issues. – Arms & Hearts (talk) 13:02, 16 September 2020 (UTC)
- That it was re-trying indicates a token error. 1119 – SD0001 (talk) 14:05, 16 September 2020 (UTC)
- Thanks – good to know people are aware of it. I probably could've found my way to that page but find Github a bit perplexing; will try to explore further in future. – Arms & Hearts (talk) 17:01, 16 September 2020 (UTC)
- My fix for #"Getting_token"_and_what? might do wonders here. ~ Amory (u • t • c) 21:03, 5 October 2020 (UTC)
- Thanks – good to know people are aware of it. I probably could've found my way to that page but find Github a bit perplexing; will try to explore further in future. – Arms & Hearts (talk) 17:01, 16 September 2020 (UTC)
"Getting token" and what?
This is concerning the RfD nomination of Ser Amantio di Nicolao at Wikipedia:Redirects for discussion/Log/2020 September 22#Ser Amantio di Nicolao (now relisted at Wikipedia:Redirects for discussion/Log/2020 September 30#Ser Amantio di Nicolao). When I published my nomination of the page, my CSRF token had already expired (as I had opened the Twinkle window the day before already), and Twinkle tried to get new tokens to be able to perform the edits. This worked for adding the discussion to the RfD log and notifying the creator, but the three other operations (adding the RfD template to the redirect, notifying the target page, and adding the entry to my XfD log) terminated with a "Getting token: done", and no actual retrial. 𝟙𝟤𝟯𝟺𝐪𝑤𝒆𝓇𝟷𝟮𝟥𝟜𝓺𝔴𝕖𝖗𝟰 (𝗍𝗮𝘭𝙠) 20:21, 5 October 2020 (UTC)
- Well that's no good! I had a quick moment before I start making dinner and I think I identified the issue. I'll do some more testing tonight and get it checked out. ~ Amory (u • t • c) 20:59, 5 October 2020 (UTC)
- Done ~ Amory (u • t • c) 00:46, 6 October 2020 (UTC)
Grant request for localising Twinkle to other wikis
I have requested a m:Rapid Grant to add internationalisation and localisation support to Twinkle (which would make it easy to port Twinkle to other wikis). Any comments and community endorsements would be welcome at the Grant request page. This task has been stalled for over 8 years. Now may be the time it actually happens! Detailed plans on how this would be achieved are on GitHub issue 1144 – SD0001 (talk) 18:33, 9 October 2020 (UTC)
You are invited to join the discussion at Wikipedia:Templates for discussion/Log/2020 October 16 § Template:Welcome-personal. {{u|Sdkb}} talk 22:09, 16 October 2020 (UTC)
October 2020 Twinkle updates (2020-10-18)
Most of the latest changes have been fairly minor and have already been live for weeks, but I wanted to note a few items beyond the minor bug fixes. Changes not otherwise attributed were made by User:Amorymeltzer.
- revert and rollback:
- speedy:
- Use Module:Module wikitext to tag modules (by Jackmcbarn)
- Note number of previous deletions (#1138)
- block: Add DS topic codes for arbitration blocks and their templates (#1039)
- talkback: Add more noticeboards (#1123)
- xfd: auto-select
type=inline
for inline templates (#1147, by SD0001) - tag: Add expiry field to Do not move to Commons (#1098)
- Better handling of connection errors (#1139, by SD0001)
- More consistent font sizes across all skins (#1128, by SD0001)
- Better handling of triage attempts (#1149 and #1150)
- Fixed linking to sections in Twinkle preferences: (#1135)
This section should serve as a catching ground should anything not work properly or if any new bugs crop up, as well as for any feedback or suggestions. There were a lot of changes behind the scenes, so feel free to ping me. As always, input is welcome at the GitHub repo as well. Finally, if you're interested in helping out with Twinkle development, there's a guideline to help new contributors get set up — check it out! ~ Amory (u • t • c) 19:01, 18 October 2020 (UTC)
Technical changes
An overview of changes to the morebits library for interested developers:
- Added ability to create a new section on a page (#1083)
- There's a new
Morebits.taskManager
(#1036, by SD0001) wikitext.template.parse
has been renamed towikitext.parseTemplate
(#1078)- preview: Add parameter to render section title (#1083)
~ Amory (u • t • c) 19:01, 18 October 2020 (UTC)
Unable to notify users
Hi everyone, I am unable to notify users when I tag for speedy delete options in Twinkle. I have my notify checkbox ticked, but still it is not notifying the users and also the user information is not available in the CSD logs. I am finding this problem from 20/10/2020. Courtesy @Amorymeltzer:. Thank you. ~ Amkgp 💬 17:42, 20 October 2020 (UTC)
- Looks like Amorymeltzer got there first. – SD0001 (talk) 18:09, 20 October 2020 (UTC)
- (edit conflict)Thanks for the report, Amkgp — that's a bug alright! Should be fixed now. ~ Amory (u • t • c) 18:13, 20 October 2020 (UTC)
Nomination for deletion of Template:No talkback
Template:No talkback has been nominated for deletion. You are invited to comment on the discussion at the entry on the Templates for discussion page. This, that and the other (talk) 00:53, 25 October 2020 (UTC)
Custom block presets?
Hello Twinkle devs, recently I have been using the Twinkle block interface however I did notice there is not a way to add block presets in your preferences. I know you can edit custom welcome and warning templates, would it be worthwhile to add the ability to add/edit custom blocks as well? Thanks! -- LuK3 (Talk) 17:53, 14 October 2020 (UTC)
- Are there specific templates you think are missing? It's possible of course, but I think blocks are an area where it's probably better to be consistent and all on the same page. ~ Amory (u • t • c) 11:16, 25 October 2020 (UTC)
- I'm realizing I misread you; sorry, bad night's sleep! You're actually asking for specific block customizations, not templates, is that right? Like "42 hours, no email" or "40 days, no talk page, partial block from projectspace"? ~ Amory (u • t • c) 11:28, 25 October 2020 (UTC)
- Amorymeltzer, correct. For example, blocking an LTA account with email and talk page access disabled and leave a specific block template. -- LuK3 (Talk) 16:40, 25 October 2020 (UTC)
- I'm realizing I misread you; sorry, bad night's sleep! You're actually asking for specific block customizations, not templates, is that right? Like "42 hours, no email" or "40 days, no talk page, partial block from projectspace"? ~ Amory (u • t • c) 11:28, 25 October 2020 (UTC)
Institutional knowledge: 'alreadyblocked'?
Hi Twinkle devs, I'm looking for some institutional knowledge regarding the block API - since there aren't many scripts which do blocks, figured you all might know something. I've seen an occasional issue in my spihelper script where I get an 'alreadyblocked' response from the API even if I've set the reblock param to true; as far as I can tell, it happens if the block params are identical to the existing block and was issued by the same person (i.e. the block would effectively only add a log entry). Have you all ever seen anything like that happen in Twinkle? GeneralNotability (talk) 20:12, 23 October 2020 (UTC)
- Not that I have institutional knowledge about this API, but looking at the mediawiki source code, you're pretty much right. It appears that "alreadyblocked" should be response if the reblock param was unset, or if the existing block is identical to the one requested. Who issued the block should not matter. (I don't have links handy as I'm reading a slightly older version of the code locally, the layout of which has changed in the live version.) – SD0001 (talk) 05:09, 24 October 2020 (UTC)
- Yeah, that's right. Blocks that are the same aren't accepted, which makes sense; what did you want to happen? ~ Amory (u • t • c) 09:36, 24 October 2020 (UTC)
- Amorymeltzer, SD0001, I thought I'd managed to do that kind of block via Twinkle before, but I could be misremembering. I think I've managed to block on top of someone else's identical block using my script before (basically changing a normal block to a sock-block). Oh well, it's not that important - thank you both for your responses! GeneralNotability (talk) 23:52, 26 October 2020 (UTC)
- Did you change literally anything? The edit summary counts! ~ Amory (u • t • c) 00:36, 27 October 2020 (UTC)
- Amorymeltzer, SD0001, I thought I'd managed to do that kind of block via Twinkle before, but I could be misremembering. I think I've managed to block on top of someone else's identical block using my script before (basically changing a normal block to a sock-block). Oh well, it's not that important - thank you both for your responses! GeneralNotability (talk) 23:52, 26 October 2020 (UTC)
CSD reasons - redux
Okay, so this was discussed a relatively short while ago, and I guess I misunderstood the discussion as being "resolved", but I just deleted Category:Thai highway map templates as G8, with the "optional message" as "all templates deleted at TFD", but that reason doesn't show up on the page or the log. Keep in mind this is me directly deleting a page via Twinkle, not nominating a page (I think that might have been the confusion in the last post). Primefac (talk) 19:14, 26 October 2020 (UTC)
- @Primefac: It's the same issue. That's {{Db-templatecat}}, which itself calls {{Db-g8}}, but notably does not pass anything to the
{{{summary}}}
parameter, meaning it will always use the default. I think there's probably also something Twinkle needs to do too — I can check tomorrow — but {{db-templatecat}} needs to at least pass on a default or something to{{{summary}}}
, otherwise nobody can make use of it. I'll try and do that survey of csd templates I mentioned sometime this coming weekend. ~ Amory (u • t • c) 00:36, 27 October 2020 (UTC)- Oh, interesting. I figured TW was using the same interface as the "regular" delete system (select deletion reason, add extra text if desired, save). Primefac (talk) 00:42, 27 October 2020 (UTC)
- Nah — piggybacks onto the little deletion link that the templates provide. ~ Amory (u • t • c) 01:00, 27 October 2020 (UTC)
- Oh, interesting. I figured TW was using the same interface as the "regular" delete system (select deletion reason, add extra text if desired, save). Primefac (talk) 00:42, 27 October 2020 (UTC)
Nomination for merging of Template:Duflu
Template:Duflu has been nominated for merging with Template:Needtrans. You are invited to comment on the discussion at the template's entry on the Templates for discussion page. Thank you. – SD0001 (talk) 06:36, 31 October 2020 (UTC)
Translation module glitches
The "needs translation" and "rough translation" modules recently developed a glitch. When the language is supplied, it's showing up in the tag placed on the article and in the edit summary at WP:Pages needing translation into English, but the {{{language}}} placeholder in the text added to WP:PNT is no longer being substituted as it used to be, so all entries now display the placeholder. What broke this, and can this be fixed? Largoplazo (talk) 04:15, 31 October 2020 (UTC)
- Fixed [10] It was caused by this edit in which LaundryPizza03 changed the parameter names used by the template. – SD0001 (talk) 06:13, 31 October 2020 (UTC)
- @SD0001:Excellent, thanks! Please ignore my ping from LaundryPizza03's talk page. I didn't bother looking at your edits and thought you had only reverted LP03's edits. I wanted to let LP03 know of the situation and solicit help in doing what I then saw you had already done (accommodating both casings). Sorry! Largoplazo (talk) 13:01, 31 October 2020 (UTC)
{{Uw-subtle1}} and other levels missing
Hello. When warning people for their edits, I found that {{Uw-subtle1}}, {{Uw-subtle2}}, {{Uw-subtle3}}, and {{Uw-subtle4}} are missing from the choice of warnings. Could you please add them? I would appreciate it. Thanks! This is my userpage[citation needed]and this is my talk page[citation needed] 03:41, 29 October 2020 (UTC)
- FWIW this was asked a few times in the past (1, 2) but didn't seem super popular. ~ Amory (u • t • c) 10:26, 29 October 2020 (UTC)
- I'd use them if they were added. I run across these sorts of edit quite a lot in aviation and military articles, and it would be useful. BilCat (talk) 04:54, 31 October 2020 (UTC)
Suggestion: add uw-subtle warning templates
Hello,
I often use Twinkle to give template warnings. One warning series that I use often is uw-subtle. This series isn't an option on Twinkle's dropdown list of user warnings, though, so I have to place it manually. Could someone please add it, or explain to me why it isn't an option if this has already been considered? Thanks. ― Tartan357 (Talk) 05:56, 1 November 2020 (UTC)
- Look three sections back. BilCat (talk) 06:01, 1 November 2020 (UTC)
I've opened up a PR to add them to Twinkle, feedback on language welcome (cc MJL). ~ Amory (u • t • c) 12:37, 1 November 2020 (UTC)
XFD for TemplateStyles
Twinkle caputted on tagging Wikipedia:Village pump (WMF)/styles.css, no doubt due to the unrecognized content model.
Not sure of the best way to handle content model sanitized-css, but I assume it should be done similar to how css is done (if it's done?), and/or how modules are done.
I've manually added {{mfd}} to the page and it is categorized, but of course the template does not display. --Izno (talk) 16:05, 4 November 2020 (UTC)
- Relevant section of WP:TFDHOWTO:
- TemplateStyles pages: The above templates will not work on TemplateStyles pages. Instead, add a CSS comment to the top of the page:
/* This template is being discussed in accordance with Wikipedia's deletion policy. Help reach a consensus at its entry: https://en.wikipedia.org/wiki/Wikipedia:Templates for discussion/Log/2024_November_30#Template:template_name.css */
--Trialpears (talk) 16:26, 4 November 2020 (UTC)
Twinkle auto-select user warning level not working
I have the auto-select user warning level feature enabled. However, it always selects level 1 no matter how many previous warnings the user has. I'm using an iPad on Firefox. Please let me know the issue. Thanks. Eyebeller (talk) 01:56, 29 October 2020 (UTC)
- Hey Eyebeller, do you have a good example of a page and revision where that's happening? I see from your contributions history that you have been giving higher level warnings, were those all manual selections? ~ Amory (u • t • c) 10:27, 29 October 2020 (UTC)
- Yes, they were manual selections. It happens on any talk page. Eyebeller (talk) 10:31, 29 October 2020 (UTC)
- Okay I see the issue now — it's not just you, I think it's all Safari users! Safari parses the date differently than Chrome or Firefox, so it's apparently not treating the timestamp that Twinkle finds as valid. I'll try and take a look at this tonight. ~ Amory (u • t • c) 11:14, 29 October 2020 (UTC)
- Ok, thanks. I should note that it works on my latop's Firefox, but not on my iPad's Firefox. Eyebeller (talk) 12:58, 29 October 2020 (UTC)
- Okay I've just pushed a fix for this, it might take a few minutes to show up for you. Thanks again for the report! The Firefox app on iOS still has to use the Safari web engine, that's required by iOS, so that's probably why you still see it there. ~ Amory (u • t • c) 11:25, 30 October 2020 (UTC)
- Hello again. I'm facing the same issue again, now Firefox on Windows 10. Eyebeller (talk) 20:28, 8 November 2020 (UTC)
- Okay I've just pushed a fix for this, it might take a few minutes to show up for you. Thanks again for the report! The Firefox app on iOS still has to use the Safari web engine, that's required by iOS, so that's probably why you still see it there. ~ Amory (u • t • c) 11:25, 30 October 2020 (UTC)
- Ok, thanks. I should note that it works on my latop's Firefox, but not on my iPad's Firefox. Eyebeller (talk) 12:58, 29 October 2020 (UTC)
- Okay I see the issue now — it's not just you, I think it's all Safari users! Safari parses the date differently than Chrome or Firefox, so it's apparently not treating the timestamp that Twinkle finds as valid. I'll try and take a look at this tonight. ~ Amory (u • t • c) 11:14, 29 October 2020 (UTC)
- Yes, they were manual selections. It happens on any talk page. Eyebeller (talk) 10:31, 29 October 2020 (UTC)
Bug fix - or is it a feature?
I needed to do an MFD on a redirect in Draft: space. Yes, this is an outlier, but it was the right thing to do, since it was the underlying edit history that is up for discussion.
Twinkle did its job fine except that it put the MFD notice on the target of the redirect, not the redirect itself.
I'm not sure if this is a bug or a feature. I think it's a bug because Twinkle notified the author of the page itself, not the target of the redirect, of the MfD. Twinkle's edits: MfD created, incorrect page (target of redirect) tagged MfD, correct editor notified, MfD log updated, and my XfD log updated. This is what Draft:Maharashtra Students Welfare Association looked like at the time: page, as a redirect. Note: I have since turned the page into a "soft redirect" for the duration of the companion AfD discussion. davidwr/(talk)/(contribs) 15:06, 9 November 2020 (UTC)
Twinkle auto-select user warning level not working (Again)
I am experiencing the same things as described here, but this time it's happening on Windows 10 Firefox too. It worked on iPad for a short while but recently it broke again. Eyebeller (talk) 07:56, 9 November 2020 (UTC)
- 1187 – SD0001 (talk) 11:41, 9 November 2020 (UTC)
- Thanks for the report Eyebeller, there was a bug in the fix I put out earlier, but only for dates 1-9. I think it should be fixed now, might take a few minutes to take effect. ~ Amory (u • t • c) 14:29, 9 November 2020 (UTC)
- Thanks, I can confirm that it works now. Eyebeller (talk) 15:37, 9 November 2020 (UTC)
Request for custom template deletion name
Hi Twinkle developers, thanks for your contributions to this amazing and exceptionally useful gadget. Currently when a template is selected and XFD selected via twinkle the prompt autocreates the TfD entry based on the template's name. However, quite commonly templates are discussed in batch form. It would be very useful if a way could be provided in the prompty (such as either a custom link or discussion name) so that all the discussions are automatically placed in the same category:
- Example of Twinkle generating separate entries: Wikipedia:Templates for discussion/Log/2020 October 8
- Example of how Twinkle could generate a single entry for multiple templates: Wikipedia:Templates_for_discussion/Log/2020_October_5#Template:R_from_historic_name
Let me know if there's any information this could provide. I am sure this feature would help save both time and effort for editors contributing to template maintenance and discussions. Thanks :) --Tom (LT) (talk) 23:45, 8 October 2020 (UTC)
- Notwithstanding that such a feature might be useful in some cases, I've already pointed out to you in another TfD page,
"The nominations are not batched, because when a batch nomination was made, it was objected to on that basis. "
. Andy Mabbett (Pigsonthewing); Talk to Andy; Andy's edits 09:16, 9 October 2020 (UTC)
- Batching nominations for RfD (and perhaps other XfD) would also be very useful. Certes (talk) 10:22, 9 October 2020 (UTC)
- This seems too obvious to have not been proposed before. I absolutely support this proposal, as this is very useful for RfD and CfD in the least. 𝟙𝟤𝟯𝟺𝐪𝑤𝒆𝓇𝟷𝟮𝟥𝟜𝓺𝔴𝕖𝖗𝟰 (𝗍𝗮𝘭𝙠) 20:10, 10 October 2020 (UTC)
- Or even just the option to nominate multiple pages in one go. Primefac (talk) 19:17, 11 October 2020 (UTC)
- Ping so that this thread doesn't get archived. --Tom (LT) (talk) 00:39, 27 October 2020 (UTC)
- Ping and pong for the same reason. Also ping to Amorymeltzer as I see you're quite active below :). --Tom (LT) (talk) 02:33, 10 November 2020 (UTC)
- Ping so that this thread doesn't get archived. --Tom (LT) (talk) 00:39, 27 October 2020 (UTC)
Feature request: SRG
The ability to file a report to globally lock an account for obvious LTA socks. 4thfile4thrank {talk} :? 14:35, 11 November 2020 (UTC)
- Try meta:User:Xiplus/TwinkleGlobal, it has this functionality. ProcrastinatingReader (talk) 21:30, 12 November 2020 (UTC)
@ProcrastinatingReader: Thanks for the answer! 4thfile4thrank {talk} :? 02:12, 13 November 2020 (UTC)
Move requests deeply hidden
The requested move feature is buried under the XfD menu, which has the tooltip "start a deletion discussion". Moves are not deletions, so it'd be nice to change how this is nested. {{u|Sdkb}} talk 00:27, 23 October 2020 (UTC)
- Agree - took me (actual) years to find this. --Tom (LT) (talk) 01:16, 25 October 2020 (UTC)
- Tom (LT), no it didn't! The feature was added less than a year back :) – SD0001 (talk) 06:36, 25 October 2020 (UTC)
- :P Well I'm glad it was added! (thank you devs!) --Tom (LT) (talk) 06:58, 25 October 2020 (UTC)
- Tom (LT), no it didn't! The feature was added less than a year back :) – SD0001 (talk) 06:36, 25 October 2020 (UTC)
- It's not ideal, but where would you think it makes more sense? It's a "nomination" or "discussion" like the other XfD options, and I don't think any of the other options are more accurate. I'd be fine with the tooltip just being "Start a discussion" though. ~ Amory (u • t • c) 10:24, 29 October 2020 (UTC)
- I would want to make the tooltip verbose and venue-specific:
- articles: "Start a discussion for deleting or moving this article"
- redirects: "Start a discussion for deleting or retargeting this redirect"
- templates: "Start a discussion for deleting or merging this template"
- categories: "Start a discussion for deleting, merging or renaming this category"
- files: "Start a deletion discussion for this file"
- misc: "Start a deletion discussion for this page"
- (not meant to be 100% complete or correct) – SD0001 (talk) 12:13, 29 October 2020 (UTC)
- Opened a PR with both these methods. ~ Amory (u • t • c) 21:22, 15 November 2020 (UTC)